You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2009/08/15 02:36:14 UTC
[jira] Created: (HDFS-546) DatanodeDescriptor block iterator should
be BlockInfo based rather than Block.
DatanodeDescriptor block iterator should be BlockInfo based rather than Block.
------------------------------------------------------------------------------
Key: HDFS-546
URL: https://issues.apache.org/jira/browse/HDFS-546
Project: Hadoop HDFS
Issue Type: Improvement
Components: name-node
Affects Versions: 0.21.0
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Fix For: 0.21.0
{{DatanodeDescriptor.BlockIterator}} currently implements {{Iterator<Block>}}. I need to change it to implement {{Iterator<BlockInfo>}} instead. Otherwise, I cannot filter out blocks under construction in order to exclude them from balancing, as Hairong suggested in HDFS-517.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-546) DatanodeDescriptor block iterator should
be BlockInfo based rather than Block.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HDFS-546:
-------------------------------------
Attachment: BlockIterator.patch
This should do.
There is no new functionality, so no new tests is required.
> DatanodeDescriptor block iterator should be BlockInfo based rather than Block.
> ------------------------------------------------------------------------------
>
> Key: HDFS-546
> URL: https://issues.apache.org/jira/browse/HDFS-546
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: BlockIterator.patch
>
>
> {{DatanodeDescriptor.BlockIterator}} currently implements {{Iterator<Block>}}. I need to change it to implement {{Iterator<BlockInfo>}} instead. Otherwise, I cannot filter out blocks under construction in order to exclude them from balancing, as Hairong suggested in HDFS-517.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-546) DatanodeDescriptor block iterator
should be BlockInfo based rather than Block.
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743505#action_12743505 ]
Hairong Kuang commented on HDFS-546:
------------------------------------
+1
> DatanodeDescriptor block iterator should be BlockInfo based rather than Block.
> ------------------------------------------------------------------------------
>
> Key: HDFS-546
> URL: https://issues.apache.org/jira/browse/HDFS-546
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: BlockIterator.patch
>
>
> {{DatanodeDescriptor.BlockIterator}} currently implements {{Iterator<Block>}}. I need to change it to implement {{Iterator<BlockInfo>}} instead. Otherwise, I cannot filter out blocks under construction in order to exclude them from balancing, as Hairong suggested in HDFS-517.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-546) DatanodeDescriptor block iterator
should be BlockInfo based rather than Block.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750428#action_12750428 ]
Hudson commented on HDFS-546:
-----------------------------
Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #6 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/6/])
> DatanodeDescriptor block iterator should be BlockInfo based rather than Block.
> ------------------------------------------------------------------------------
>
> Key: HDFS-546
> URL: https://issues.apache.org/jira/browse/HDFS-546
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: BlockIterator.patch
>
>
> {{DatanodeDescriptor.BlockIterator}} currently implements {{Iterator<Block>}}. I need to change it to implement {{Iterator<BlockInfo>}} instead. Otherwise, I cannot filter out blocks under construction in order to exclude them from balancing, as Hairong suggested in HDFS-517.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-546) DatanodeDescriptor block iterator should
be BlockInfo based rather than Block.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HDFS-546:
-------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> DatanodeDescriptor block iterator should be BlockInfo based rather than Block.
> ------------------------------------------------------------------------------
>
> Key: HDFS-546
> URL: https://issues.apache.org/jira/browse/HDFS-546
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: BlockIterator.patch
>
>
> {{DatanodeDescriptor.BlockIterator}} currently implements {{Iterator<Block>}}. I need to change it to implement {{Iterator<BlockInfo>}} instead. Otherwise, I cannot filter out blocks under construction in order to exclude them from balancing, as Hairong suggested in HDFS-517.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-546) DatanodeDescriptor block iterator should
be BlockInfo based rather than Block.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HDFS-546:
-------------------------------------
Status: Patch Available (was: Open)
> DatanodeDescriptor block iterator should be BlockInfo based rather than Block.
> ------------------------------------------------------------------------------
>
> Key: HDFS-546
> URL: https://issues.apache.org/jira/browse/HDFS-546
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: BlockIterator.patch
>
>
> {{DatanodeDescriptor.BlockIterator}} currently implements {{Iterator<Block>}}. I need to change it to implement {{Iterator<BlockInfo>}} instead. Otherwise, I cannot filter out blocks under construction in order to exclude them from balancing, as Hairong suggested in HDFS-517.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-546) DatanodeDescriptor block iterator
should be BlockInfo based rather than Block.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744053#action_12744053 ]
Hudson commented on HDFS-546:
-----------------------------
Integrated in Hadoop-Hdfs-trunk #52 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/52/])
. DatanodeDescriptor iterator blocks as BlockInfo. Contributed by Konstantin Shvachko.
> DatanodeDescriptor block iterator should be BlockInfo based rather than Block.
> ------------------------------------------------------------------------------
>
> Key: HDFS-546
> URL: https://issues.apache.org/jira/browse/HDFS-546
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: BlockIterator.patch
>
>
> {{DatanodeDescriptor.BlockIterator}} currently implements {{Iterator<Block>}}. I need to change it to implement {{Iterator<BlockInfo>}} instead. Otherwise, I cannot filter out blocks under construction in order to exclude them from balancing, as Hairong suggested in HDFS-517.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-546) DatanodeDescriptor block iterator
should be BlockInfo based rather than Block.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750459#action_12750459 ]
Hudson commented on HDFS-546:
-----------------------------
Integrated in Hadoop-Hdfs-trunk #70 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/70/])
. Fix a typo in CHANGES.txt
> DatanodeDescriptor block iterator should be BlockInfo based rather than Block.
> ------------------------------------------------------------------------------
>
> Key: HDFS-546
> URL: https://issues.apache.org/jira/browse/HDFS-546
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: BlockIterator.patch
>
>
> {{DatanodeDescriptor.BlockIterator}} currently implements {{Iterator<Block>}}. I need to change it to implement {{Iterator<BlockInfo>}} instead. Otherwise, I cannot filter out blocks under construction in order to exclude them from balancing, as Hairong suggested in HDFS-517.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-546) DatanodeDescriptor block iterator
should be BlockInfo based rather than Block.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750266#action_12750266 ]
Hudson commented on HDFS-546:
-----------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #10 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/10/])
. Fix a typo in CHANGES.txt
> DatanodeDescriptor block iterator should be BlockInfo based rather than Block.
> ------------------------------------------------------------------------------
>
> Key: HDFS-546
> URL: https://issues.apache.org/jira/browse/HDFS-546
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: BlockIterator.patch
>
>
> {{DatanodeDescriptor.BlockIterator}} currently implements {{Iterator<Block>}}. I need to change it to implement {{Iterator<BlockInfo>}} instead. Otherwise, I cannot filter out blocks under construction in order to exclude them from balancing, as Hairong suggested in HDFS-517.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-546) DatanodeDescriptor block iterator
should be BlockInfo based rather than Block.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743540#action_12743540 ]
Hadoop QA commented on HDFS-546:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12416632/BlockIterator.patch
against trunk revision 804127.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/68/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/68/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/68/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/68/console
This message is automatically generated.
> DatanodeDescriptor block iterator should be BlockInfo based rather than Block.
> ------------------------------------------------------------------------------
>
> Key: HDFS-546
> URL: https://issues.apache.org/jira/browse/HDFS-546
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.0
>
> Attachments: BlockIterator.patch
>
>
> {{DatanodeDescriptor.BlockIterator}} currently implements {{Iterator<Block>}}. I need to change it to implement {{Iterator<BlockInfo>}} instead. Otherwise, I cannot filter out blocks under construction in order to exclude them from balancing, as Hairong suggested in HDFS-517.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.