You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "laskoviymishka (via GitHub)" <gi...@apache.org> on 2026/04/03 14:46:14 UTC
[I] fix: ReplaceDataFiles should use OpReplace instead of OpOverwrite [iceberg-go]
laskoviymishka opened a new issue, #841:
URL: https://github.com/apache/iceberg-go/issues/841
### Apache Iceberg version
main (development)
### Please describe the bug 🐞
Parent: #832
`ReplaceDataFiles` at `transaction.go:349` has a TODO noting the operation should be `OpReplace` (data is reorganized, not changed) but unconditionally uses `OpOverwrite` because there is no validation. Per the Iceberg spec, `REPLACE` means the data content is equivalent — just reorganized into different files. This is the correct operation for compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] fix: ReplaceDataFiles should use OpReplace instead of OpOverwrite [iceberg-go]
Posted by "tanmayrauth (via GitHub)" <gi...@apache.org>.
tanmayrauth commented on issue #841:
URL: https://github.com/apache/iceberg-go/issues/841#issuecomment-4263583211
Sure, I will ping you on slack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] fix: ReplaceDataFiles should use OpReplace instead of OpOverwrite [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade closed issue #841: fix: ReplaceDataFiles should use OpReplace instead of OpOverwrite
URL: https://github.com/apache/iceberg-go/issues/841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] fix: ReplaceDataFiles should use OpReplace instead of OpOverwrite [iceberg-go]
Posted by "tanmayrauth (via GitHub)" <gi...@apache.org>.
tanmayrauth commented on issue #841:
URL: https://github.com/apache/iceberg-go/issues/841#issuecomment-4216321425
@laskoviymishka @kevinjqliu Can I work on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] fix: ReplaceDataFiles should use OpReplace instead of OpOverwrite [iceberg-go]
Posted by "tanmayrauth (via GitHub)" <gi...@apache.org>.
tanmayrauth commented on issue #841:
URL: https://github.com/apache/iceberg-go/issues/841#issuecomment-4263337429
@laskoviymishka can I pick up issue and resolve the review comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] fix: ReplaceDataFiles should use OpReplace instead of OpOverwrite [iceberg-go]
Posted by "tanmayrauth (via GitHub)" <gi...@apache.org>.
tanmayrauth commented on issue #841:
URL: https://github.com/apache/iceberg-go/issues/841#issuecomment-4615576166
I think we can close this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] fix: ReplaceDataFiles should use OpReplace instead of OpOverwrite [iceberg-go]
Posted by "laskoviymishka (via GitHub)" <gi...@apache.org>.
laskoviymishka commented on issue #841:
URL: https://github.com/apache/iceberg-go/issues/841#issuecomment-4263432948
I think it's better to give some time to @Bahtya to resolve it and have a chance to land this PR on his own.
If you looking to stuff to pickup, i think https://github.com/apache/iceberg-go/issues/831 this one could be a good candidate.
If you are willing to contribute more - plz reach me in slack, i don't file all issue here, but there is a plenty of work left in general
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] fix: ReplaceDataFiles should use OpReplace instead of OpOverwrite [iceberg-go]
Posted by "laskoviymishka (via GitHub)" <gi...@apache.org>.
laskoviymishka commented on issue #841:
URL: https://github.com/apache/iceberg-go/issues/841#issuecomment-4217699639
There is already a pr for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org