You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Thorsten Scherler <th...@apache.org> on 2005/10/19 10:17:28 UTC

Re: [jira] Commented: (FOR-675) upgrading to commons-jxpath-1.2.jar causes failures with linkrewriter protocols site: etc.

El mar, 18-10-2005 a las 19:19 +1000, David Crossley escribió:
> Ross Gardler wrote:
> > David Crossley (JIRA) wrote:
> > >    [ 
> > >    http://issues.apache.org/jira/browse/FOR-675?page=comments#action_12332323 ] 
> > >
> > >David Crossley commented on FOR-675:
> > >------------------------------------
> > >
> > >There is a simple way to avoid these issues.
> > >
> > >Remove the xmlns attribute from every site.xml and make the following 
> > >change. The linkrewriter can then be used with the updated JXPath library.
> > 
> > Is this is a robust workaround? I'm not intimate enough with the 
> > navigation generation to be able to predict the potential side effects 
> > of this.
> 
> I don't know either, but everything seems to be working.
> 
> Haven't tried the views dispatcher yet.

I will do that.

> It is a drastic change, but this issue is too.

jeje, just wait till I have the first version ready. ;-) While doing the
lm rewrite of the dispatcher I found many parts of the processing that
we should change that we can use contracts in e.g. xml processing of the
data model.

> One thing that it would affect is the future ability to have
> a new version of the namespace. I reckon that we should
> sacrifice that to get past this bug.

+1 

We can always bring it back, if we (or somebody else) can fix the bug.

> > (by the way, thank you David for keeping at this issue, I've been hiding 
> > from it ;-)
> 
> Thanks, i have been spending a huge amount of time on it.
> I have been deep in Cocoon input modules and JXPath,
> but i am not getting far. It needs someone with better
> Java/XML/Namespace/Cocoon foo.

Yeah thx very much, David. I tried for a while but there many components
involved. It is pretty heavy to understand each component before being
able to fix this bug. Again thx David that you are doing this, it is
most valuable for forrest.

> 
> I see this as a crucial issue. We now have various
> whiteboard plugins with fixme comments about JXPath
> and disabled linkrewriter sitemaps and duplicated
> documentation trying to explain all that. 

It is even worse because if we e.g. want a cform plugin then this will
have another of this fixme notes. :/ trying to say that many blocks of
cocoon depending on JX 1.2.

> And it is
> preventing me working on real issues.

Yeah, we should propose to drop the ns for the time this bug is being
fixed and go on with our work.

+1

Anyway, as soon as v2 is totally based on the lm, I will give it another
go. (hopefully then I have internet @home again)

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Re: [jira] Commented: (FOR-675) upgrading commons-jxpath-1.2.jar

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> David Crossley escribi??:
> > Ross Gardler wrote:
> > > Thorsten Scherler wrote:
> > > >David Crossley escribi??:
> > > >
> > > >>And it is
> > > >>preventing me working on real issues.
> > > >
> > > >Yeah, we should propose to drop the ns for the time this bug is being
> > > >fixed and go on with our work.
> > > >
> > > >+1
> > 
> > It is not so easy. Every user out there of 0.8-dev
> > would need to remove the namespace from their site.xml
> > 
> > I am hoping to find a way to automatically remove it
> > before forrest uses the file. Otherwise it will need
> > to be an upgrading_08 note.
> 
> Actually that should not be so hard. We "only" have to use the
> strip_namespace.xsl when requesting the site.xml. I can do that if we
> want to do it. The plan is to add a preparation pipeline and change the
> lm to return this pipe (like cocoon://prepare.site.xml). I am using
> cocoon:// protocol in the lm-structurer.xml. It is working fine.

Hmmm, i thought that i had it working. After a final test
it wasn't. Would someone please look at the new stylesheet
main/webapp/resources/stylesheets/strip-default-namespace.xsl

Insert that transformer (or fix it if not correct) at
main/webapp/linkmap.xmap line 68 for "abs-linkmap"
main/webapp/menu.xmap line 65 for "abs-menulinks"

Replace "f:site" with "site" at
main/webapp/resources/stylesheets/site-to-book.xsl line 34

Replace lib/core/commons-jxpath-20030909.jar with commons-jxpath-1.2.jar

-David

> > > >Anyway, as soon as v2 is totally based on the lm, I will give it another
> > > >go. (hopefully then I have internet @home again)
> > > 
> > > This issue is not affecting my current work directly, but if it is 
> > > holding other devs up then I'm OK with this (it will affect me soon anyway).
> > 
> > My main problem is that it is causing general confusion.
> > It is very bad for community-building to have different
> > versions of whiteboard plugins and duplicated docs, etc.
> 
> agree
> 
> salu2
> -- 
> thorsten

Re: [jira] Commented: (FOR-675) upgrading commons-jxpath-1.2.jar

Posted by Thorsten Scherler <th...@apache.org>.
El mié, 19-10-2005 a las 18:51 +1000, David Crossley escribió:
> Ross Gardler wrote:
> > Thorsten Scherler wrote:
> > >David Crossley escribi??:
> > >
> > >>And it is
> > >>preventing me working on real issues.
> > >
> > >Yeah, we should propose to drop the ns for the time this bug is being
> > >fixed and go on with our work.
> > >
> > >+1
> 
> It is not so easy. Every user out there of 0.8-dev
> would need to remove the namespace from their site.xml
> 
> I am hoping to find a way to automatically remove it
> before forrest uses the file. Otherwise it will need
> to be an upgrading_08 note.

Actually that should not be so hard. We "only" have to use the
strip_namespace.xsl when requesting the site.xml. I can do that if we
want to do it. The plan is to add a preparation pipeline and change the
lm to return this pipe (like cocoon://prepare.site.xml). I am using
cocoon:// protocol in the lm-structurer.xml. It is working fine.

> 
> > >Anyway, as soon as v2 is totally based on the lm, I will give it another
> > >go. (hopefully then I have internet @home again)
> > 
> > This issue is not affecting my current work directly, but if it is 
> > holding other devs up then I'm OK with this (it will affect me soon anyway).
> 
> My main problem is that it is causing general confusion.
> It is very bad for community-building to have different
> versions of whiteboard plugins and duplicated docs, etc.

agree

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Re: [jira] Commented: (FOR-675) upgrading commons-jxpath-1.2.jar

Posted by David Crossley <cr...@apache.org>.
Ross Gardler wrote:
> Thorsten Scherler wrote:
> >David Crossley escribi??:
> >
> >>And it is
> >>preventing me working on real issues.
> >
> >Yeah, we should propose to drop the ns for the time this bug is being
> >fixed and go on with our work.
> >
> >+1

It is not so easy. Every user out there of 0.8-dev
would need to remove the namespace from their site.xml

I am hoping to find a way to automatically remove it
before forrest uses the file. Otherwise it will need
to be an upgrading_08 note.

> >Anyway, as soon as v2 is totally based on the lm, I will give it another
> >go. (hopefully then I have internet @home again)
> 
> This issue is not affecting my current work directly, but if it is 
> holding other devs up then I'm OK with this (it will affect me soon anyway).

My main problem is that it is causing general confusion.
It is very bad for community-building to have different
versions of whiteboard plugins and duplicated docs, etc.

-David

Re: [jira] Commented: (FOR-675) upgrading to commons-jxpath-1.2.jar causes failures with linkrewriter protocols site: etc.

Posted by Ross Gardler <rg...@apache.org>.
Thorsten Scherler wrote:
> El mar, 18-10-2005 a las 19:19 +1000, David Crossley escribió:
> 

...

>>>David Crossley (JIRA) wrote:

...

>>And it is
>>preventing me working on real issues.
> 
> 
> Yeah, we should propose to drop the ns for the time this bug is being
> fixed and go on with our work.
> 
> +1
> 
> Anyway, as soon as v2 is totally based on the lm, I will give it another
> go. (hopefully then I have internet @home again)

This issue is not affecting my current work directly, but if it is 
holding other devs up then I'm OK with this (it will affect me soon anyway).

Ross