You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Gary Gregory <ga...@gmail.com> on 2018/11/07 21:33:57 UTC

Request for HttpCore 5 beta 6

Hi Oleg,

The fixes you and the other fellow did around code like AsyncDataConsumer
have addresses bugs I saw I thought were in my code. Is there any chance we
can push these out to a Beta 6 ASAP?

Thank you,
Gary

Re: Request for HttpCore 5 beta 6

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Thu, 2018-11-08 at 08:29 -0700, Gary Gregory wrote:
> 

...

> 
> You're saying that this falls under API improvements as well? It
> seems a
> lot more than that, and the behavior of my app is the better for it
> based
> on one day of testing, I no longer see the timeouts I mentioned in
> another
> email thread, but maybe my problem has just moved around. I am doing
> more
> testing...
> 

It was truly meant to be just an API tweak with no functional impact. I
do suspect that your problem just might gotten moved around. The
timeout exceptions you were seeing are perfectly normal. You should be
more worried if you do not see them.

I have no problem with rushing another BETA release but would hate to
do it for no good reason.

Cheers

Oleg 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: Request for HttpCore 5 beta 6

Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Nov 8, 2018 at 3:08 AM Oleg Kalnichevski <ol...@apache.org> wrote:

> On Wed, 2018-11-07 at 14:33 -0700, Gary Gregory wrote:
> > Hi Oleg,
> >
> > The fixes you and the other fellow did around code like
> > AsyncDataConsumer
> > have addresses bugs I saw I thought were in my code. Is there any
> > chance we
> > can push these out to a Beta 6 ASAP?
> >
> > Thank you,
> > Gary
>
> Hi Gary
>
> All bug fixes got included into BETA5
>
>
> https://github.com/apache/httpcomponents-core/commit/277c628607e05c62d6fa9130a77ef7361aa6a49a
>
> The change I committed after the BETA5 release was an API improvement,
> not a bug fix
>
>
> https://github.com/apache/httpcomponents-core/commit/3252c39fd803f86c6856caa83b683d31e45b8391


OK, but there are changes in AbstractHttp1StreamDuplexer.java
<https://github.com/apache/httpcomponents-core/commit/3252c39fd803f86c6856caa83b683d31e45b8391#diff-4ceed36abd5cb9433de24f108c90195a>
that
affect behavior:
https://github.com/apache/httpcomponents-core/commit/3252c39fd803f86c6856caa83b683d31e45b8391#diff-4ceed36abd5cb9433de24f108c90195a


You're saying that this falls under API improvements as well? It seems a
lot more than that, and the behavior of my app is the better for it based
on one day of testing, I no longer see the timeouts I mentioned in another
email thread, but maybe my problem has just moved around. I am doing more
testing...

Gary

>
>
> Oleg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>

Re: Request for HttpCore 5 beta 6

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Wed, 2018-11-07 at 14:33 -0700, Gary Gregory wrote:
> Hi Oleg,
> 
> The fixes you and the other fellow did around code like
> AsyncDataConsumer
> have addresses bugs I saw I thought were in my code. Is there any
> chance we
> can push these out to a Beta 6 ASAP?
> 
> Thank you,
> Gary

Hi Gary

All bug fixes got included into BETA5

https://github.com/apache/httpcomponents-core/commit/277c628607e05c62d6fa9130a77ef7361aa6a49a

The change I committed after the BETA5 release was an API improvement,
not a bug fix

https://github.com/apache/httpcomponents-core/commit/3252c39fd803f86c6856caa83b683d31e45b8391

Oleg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org