[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages
URL: https://github.com/apache/hadoop-ozone/pull/94#discussion_r341191061
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/AddAclBucketHandler.java
 ##########
 @@ -91,7 +91,11 @@ public Void call() throws Exception {
     boolean result = client.getObjectStore().addAcl(obj,
         OzoneAcl.parseAcl(acl));
 
-    System.out.printf("%s%n", "Acl added successfully: " + result);
+    String message = result
+        ? ("Acl added successfully: ") + result
 
 Review comment:
   Can we change this message if true: Acl added successfully, in false, Acl already exists.
   I think in false case printing Acl added successfully: false Acl already exists which is not great in my view. Let me know your thoughts on this. Same is applicable for all Handlers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org