You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/23 19:08:41 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #615:
tools/sethost.sh & tools/configure.c: When no make argument is passed,
silence make output.
Ouss4 opened a new pull request #615: tools/sethost.sh & tools/configure.c: When no make argument is passed, silence make output.
URL: https://github.com/apache/incubator-nuttx/pull/615
With -d option removed in a previous PR, sethost.sh (and configure.c) always print make output, sometimes important information get lost in the middle of all that output.
If this one gets merged I guess #605 will be redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #615: tools/sethost.sh & tools/configure.c: When no make argument
is passed, silence make output.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #615: tools/sethost.sh & tools/configure.c: When no make argument is passed, silence make output.
URL: https://github.com/apache/incubator-nuttx/pull/615#discussion_r396694039
##########
File path: tools/sethost.sh
##########
@@ -211,4 +211,9 @@ fi
sed -i -e "/CONFIG_HOST_OTHER/d" $nuttx/.config
echo " Refreshing..."
-make olddefconfig $* || { echo "ERROR: failed to refresh"; exit 1; }
+
+if [ ! -z $* ]; then
Review comment:
How about we check S* contain V=1or V=2 instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #615: tools/sethost.sh & tools/configure.c: When no make argument
is passed, silence make output.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #615: tools/sethost.sh & tools/configure.c: When no make argument is passed, silence make output.
URL: https://github.com/apache/incubator-nuttx/pull/615#discussion_r396705793
##########
File path: tools/sethost.sh
##########
@@ -211,4 +211,9 @@ fi
sed -i -e "/CONFIG_HOST_OTHER/d" $nuttx/.config
echo " Refreshing..."
-make olddefconfig $* || { echo "ERROR: failed to refresh"; exit 1; }
+
+if [ ! -z $* ]; then
Review comment:
> To only keep V=1? No other option is useful?
other option is also useful(like -j8), but V=? has the similar semantics:
1.If the extra command line contain V=1, remove "1>/dev/null"
2.Otherwise, add "1> /dev/null".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #615: tools/sethost.sh & tools/configure.c: When no make argument
is passed, silence make output.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #615: tools/sethost.sh & tools/configure.c: When no make argument is passed, silence make output.
URL: https://github.com/apache/incubator-nuttx/pull/615#discussion_r396706158
##########
File path: tools/configure.c
##########
@@ -382,10 +382,18 @@ static int run_make(const char *arg)
char **argv;
snprintf(g_buffer, BUFFER_SIZE, "make %s", arg);
- for (argv = g_makeargv; *argv; argv++)
+
+ if (!*g_makeargv)
+ {
+ strncat(g_buffer, " 1>/dev/null", BUFFER_SIZE - 1);
Review comment:
Window native don't have /dev/null, need do something like the previous code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #615:
tools/sethost.sh & tools/configure.c: When no make argument is passed,
silence make output.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #615: tools/sethost.sh & tools/configure.c: When no make argument is passed, silence make output.
URL: https://github.com/apache/incubator-nuttx/pull/615#discussion_r396694958
##########
File path: tools/sethost.sh
##########
@@ -211,4 +211,9 @@ fi
sed -i -e "/CONFIG_HOST_OTHER/d" $nuttx/.config
echo " Refreshing..."
-make olddefconfig $* || { echo "ERROR: failed to refresh"; exit 1; }
+
+if [ ! -z $* ]; then
Review comment:
To only keep V=1? No other option is useful?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #615: tools/sethost.sh & tools/configure.c: When no make argument
is passed, silence make output.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #615: tools/sethost.sh & tools/configure.c: When no make argument is passed, silence make output.
URL: https://github.com/apache/incubator-nuttx/pull/615#discussion_r396694039
##########
File path: tools/sethost.sh
##########
@@ -211,4 +211,9 @@ fi
sed -i -e "/CONFIG_HOST_OTHER/d" $nuttx/.config
echo " Refreshing..."
-make olddefconfig $* || { echo "ERROR: failed to refresh"; exit 1; }
+
+if [ ! -z $* ]; then
Review comment:
How about we check V=1 instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #615:
tools/sethost.sh & tools/configure.c: When no make argument is passed,
silence make output.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #615: tools/sethost.sh & tools/configure.c: When no make argument is passed, silence make output.
URL: https://github.com/apache/incubator-nuttx/pull/615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #615:
tools/sethost.sh & tools/configure.c: When no make argument is passed,
silence make output.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #615: tools/sethost.sh & tools/configure.c: When no make argument is passed, silence make output.
URL: https://github.com/apache/incubator-nuttx/pull/615#discussion_r396745102
##########
File path: tools/configure.c
##########
@@ -382,10 +382,18 @@ static int run_make(const char *arg)
char **argv;
snprintf(g_buffer, BUFFER_SIZE, "make %s", arg);
- for (argv = g_makeargv; *argv; argv++)
+
+ if (!*g_makeargv)
+ {
+ strncat(g_buffer, " 1>/dev/null", BUFFER_SIZE - 1);
Review comment:
Good catch. I'll fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #615: tools/sethost.sh & tools/configure.c: When no make argument
is passed, silence make output.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #615: tools/sethost.sh & tools/configure.c: When no make argument is passed, silence make output.
URL: https://github.com/apache/incubator-nuttx/pull/615#discussion_r396694039
##########
File path: tools/sethost.sh
##########
@@ -211,4 +211,9 @@ fi
sed -i -e "/CONFIG_HOST_OTHER/d" $nuttx/.config
echo " Refreshing..."
-make olddefconfig $* || { echo "ERROR: failed to refresh"; exit 1; }
+
+if [ ! -z $* ]; then
Review comment:
How about we check S* contain V=1 instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services