You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/01 12:13:26 UTC
[GitHub] [pulsar] nicoloboschi commented on a change in pull request #14510: [Transaction] Fix topicTransactionBuffer handle null snapshot (#12758)
nicoloboschi commented on a change in pull request #14510:
URL: https://github.com/apache/pulsar/pull/14510#discussion_r816715098
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
##########
@@ -472,12 +472,15 @@ public void run() {
try {
while (reader.hasMoreEvents()) {
Message<TransactionBufferSnapshot> message = reader.readNext();
- TransactionBufferSnapshot transactionBufferSnapshot = message.getValue();
- if (topic.getName().equals(transactionBufferSnapshot.getTopicName())) {
- callBack.handleSnapshot(transactionBufferSnapshot);
- this.startReadCursorPosition = PositionImpl.get(
- transactionBufferSnapshot.getMaxReadPositionLedgerId(),
- transactionBufferSnapshot.getMaxReadPositionEntryId());
+ if (topic.getName().equals(message.getKey())) {
+ TransactionBufferSnapshot transactionBufferSnapshot = message.getValue();
+ if (transactionBufferSnapshot != null) {
+ hasSnapshot = true;
Review comment:
this should be removed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org