You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Blake Bender (Jira)" <ji...@apache.org> on 2020/07/08 19:38:01 UTC

[jira] [Resolved] (GEODE-8336) Set statistics-sampling-enabled false everywhere we don't need/want stats

     [ https://issues.apache.org/jira/browse/GEODE-8336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blake Bender resolved GEODE-8336.
---------------------------------
    Resolution: Won't Fix

tl;dr: yes, stats are disabled.

I changed all instances where we set this to true to false, and ran a private CI pipeline. 3 tests failed, all of which were checking specifically for stats to be enabled. Changing those back yielded a change with only two instances of the variable, both of which were clearly server-side settings, so there's no need to submit a PR for this or anything.

> Set statistics-sampling-enabled false everywhere we don't need/want stats
> -------------------------------------------------------------------------
>
>                 Key: GEODE-8336
>                 URL: https://issues.apache.org/jira/browse/GEODE-8336
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Blake Bender
>            Priority: Major
>
> Statistics gathering isn't necessary in our tests, unless we're specifically testing stats, and stats have long been a source of problems at client shutdown.  We should, therefore, make sure this value is set to false wherever we find it in various config files and source files in the repository.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)