[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1126: system/note: correct unflatten format

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #1126:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1126#discussion_r844650188


##########
system/sched_note/note_main.c:
##########
@@ -90,27 +90,35 @@ static FAR const char *g_statenames[] =
 static void trace_dump_unflatten(FAR void *dst,
                                  FAR uint8_t *src, size_t len)
 {
+#ifdef CONFIG_HAVE_LONG_LONG
+  uint64_t tmp = 0;
+#else
+  uint32_t tmp = 0;
+#endif
+
   switch (len)
     {
 #ifdef CONFIG_HAVE_LONG_LONG
       case 8:
-        *(uint64_t *)dst = ((uint64_t)src[7] << 56)
-                         + ((uint64_t)src[6] << 48)
-                         + ((uint64_t)src[5] << 40)
-                         + ((uint64_t)src[4] << 32);
+        tmp += ((uint64_t)src[7] << 56);
+        tmp += ((uint64_t)src[6] << 48);
+        tmp += ((uint64_t)src[5] << 40);
+        tmp += ((uint64_t)src[4] << 32);

Review Comment:
   let's follow the same change:
   https://github.com/apache/incubator-nuttx/pull/5992



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org