You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/24 09:56:19 UTC

[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9170: [feature-wip](array-type) array_contains support more nested data types

cambyzju commented on code in PR #9170:
URL: https://github.com/apache/incubator-doris/pull/9170#discussion_r857100176


##########
gensrc/script/doris_builtins_functions.py:
##########
@@ -117,67 +117,45 @@
     [['array'], 'ARRAY', ['ARRAY', '...'], '', '', '', '', ''],
     [['array'], 'ARRAY', ['MAP', '...'], '', '', '', '', ''],
     [['array'], 'ARRAY', ['STRUCT', '...'], '', '', '', '', ''],
-    [['%element_extract%'], 'VARCHAR', ['MAP', 'VARCHAR'],  '', '', '', '', ''],
-    [['%element_extract%'], 'VARCHAR', ['MAP', 'INT'],  '', '', '', '', ''],
-    [['%element_extract%'], 'VARCHAR', ['STRUCT', 'INT'],  '', '', '', '', ''],
-    [['%element_extract%'], 'VARCHAR', ['STRUCT', 'VARCHAR'],  '', '', '', '', ''],
 
-    [['element_at', '%element_extract%'], 'TINYINT', ['ARRAY_TINYINT', 'INT'],
-        '_ZN5doris10vectorized20FunctionArrayElement12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
+    [['element_at', '%element_extract%'], 'TINYINT', ['ARRAY_TINYINT', 'INT'], '', 
         '', '', 'vec', 'ALWAYS_NULLABLE'],
-    [['element_at', '%element_extract%'], 'SMALLINT', ['ARRAY_SMALLINT', 'INT'],
-        '_ZN5doris10vectorized20FunctionArrayElement12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
+    [['element_at', '%element_extract%'], 'SMALLINT', ['ARRAY_SMALLINT', 'INT'], '',
         '', '', 'vec', 'ALWAYS_NULLABLE'],
-    [['element_at', '%element_extract%'], 'INT', ['ARRAY_INT', 'INT'],
-        '_ZN5doris10vectorized20FunctionArrayElement12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
+    [['element_at', '%element_extract%'], 'INT', ['ARRAY_INT', 'INT'], '',
         '', '', 'vec', 'ALWAYS_NULLABLE'],
-    [['element_at', '%element_extract%'], 'BIGINT', ['ARRAY_BIGINT', 'INT'],
-        '_ZN5doris10vectorized20FunctionArrayElement12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
+    [['element_at', '%element_extract%'], 'BIGINT', ['ARRAY_BIGINT', 'INT'], '',
         '', '', 'vec', 'ALWAYS_NULLABLE'],
-    [['element_at', '%element_extract%'], 'VARCHAR', ['ARRAY_VARCHAR', 'INT'],
-        '_ZN5doris10vectorized20FunctionArrayElement12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
+    [['element_at', '%element_extract%'], 'VARCHAR', ['ARRAY_VARCHAR', 'INT'], '',
         '', '', 'vec', 'ALWAYS_NULLABLE'],
-    [['element_at', '%element_extract%'], 'STRING', ['ARRAY_STRING', 'INT'],
-        '_ZN5doris10vectorized20FunctionArrayElement12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
+    [['element_at', '%element_extract%'], 'STRING', ['ARRAY_STRING', 'INT'], '',
         '', '', 'vec', 'ALWAYS_NULLABLE'],
 
-    [['array_contains'], 'BOOLEAN', ['ARRAY', 'TINYINT'],
-        '_ZN5doris10vectorized18FunctionArrayIndexINS0_19ArrayContainsActionENS0_17NameArrayContainsEE12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
-        '', '', 'vec', ''],
-    [['array_contains'], 'BOOLEAN', ['ARRAY', 'SMALLINT'],
-        '_ZN5doris10vectorized18FunctionArrayIndexINS0_19ArrayContainsActionENS0_17NameArrayContainsEE12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
-        '', '', 'vec', ''],
-    [['array_contains'], 'BOOLEAN', ['ARRAY', 'INT'],
-        '_ZN5doris10vectorized18FunctionArrayIndexINS0_19ArrayContainsActionENS0_17NameArrayContainsEE12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
-        '', '', 'vec', ''],
-    [['array_contains'], 'BOOLEAN', ['ARRAY', 'BIGINT'],
-        '_ZN5doris10vectorized18FunctionArrayIndexINS0_19ArrayContainsActionENS0_17NameArrayContainsEE12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
-        '', '', 'vec', ''],
-    [['array_contains'], 'BOOLEAN', ['ARRAY', 'VARCHAR'],
-        '_ZN5doris10vectorized18FunctionArrayIndexINS0_19ArrayContainsActionENS0_17NameArrayContainsEE12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
-        '', '', 'vec', ''],
-    [['array_contains'], 'BOOLEAN', ['ARRAY', 'STRING'],
-        '_ZN5doris10vectorized18FunctionArrayIndexINS0_19ArrayContainsActionENS0_17NameArrayContainsEE12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
-        '', '', 'vec', ''],
-
-    [['array_position'], 'BIGINT', ['ARRAY', 'TINYINT'],
-        '_ZN5doris10vectorized18FunctionArrayIndexINS0_19ArrayPositionActionENS0_17NameArrayPositionEE12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
-        '', '', 'vec', ''],
-    [['array_position'], 'BIGINT', ['ARRAY', 'SMALLINT'],
-        '_ZN5doris10vectorized18FunctionArrayIndexINS0_19ArrayPositionActionENS0_17NameArrayPositionEE12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
-        '', '', 'vec', ''],
-    [['array_position'], 'BIGINT', ['ARRAY', 'INT'],
-        '_ZN5doris10vectorized18FunctionArrayIndexINS0_19ArrayPositionActionENS0_17NameArrayPositionEE12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
-        '', '', 'vec', ''],
-    [['array_position'], 'BIGINT', ['ARRAY', 'BIGINT'],
-        '_ZN5doris10vectorized18FunctionArrayIndexINS0_19ArrayPositionActionENS0_17NameArrayPositionEE12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
-        '', '', 'vec', ''],
-    [['array_position'], 'BIGINT', ['ARRAY', 'VARCHAR'],
-        '_ZN5doris10vectorized18FunctionArrayIndexINS0_19ArrayPositionActionENS0_17NameArrayPositionEE12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
-        '', '', 'vec', ''],
-    [['array_position'], 'BIGINT', ['ARRAY', 'STRING'],
-        '_ZN5doris10vectorized18FunctionArrayIndexINS0_19ArrayPositionActionENS0_17NameArrayPositionEE12execute_implEPN9doris_udf15FunctionContextERNS0_5BlockERKSt6vectorImSaImEEmm',
-        '', '', 'vec', ''],
+    [['array_contains'], 'BOOLEAN', ['ARRAY_TINYINT', 'TINYINT'], '', '', '', 'vec', ''],
+    [['array_contains'], 'BOOLEAN', ['ARRAY_SMALLINT', 'SMALLINT'], '', '', '', 'vec', ''],
+    [['array_contains'], 'BOOLEAN', ['ARRAY_INT', 'INT'], '', '', '', 'vec', ''],
+    [['array_contains'], 'BOOLEAN', ['ARRAY_BIGINT', 'BIGINT'], '', '', '', 'vec', ''],
+    [['array_contains'], 'BOOLEAN', ['ARRAY_LARGEINT', 'LARGEINT'], '', '', '', 'vec', ''],
+    [['array_contains'], 'BOOLEAN', ['ARRAY_DATETIME', 'DATETIME'], '', '', '', 'vec', ''],
+    [['array_contains'], 'BOOLEAN', ['ARRAY_DATE', 'DATE'], '', '', '', 'vec', ''],
+    [['array_contains'], 'BOOLEAN', ['ARRAY_FLOAT', 'FLOAT'], '', '', '', 'vec', ''],
+    [['array_contains'], 'BOOLEAN', ['ARRAY_DOUBLE', 'DOUBLE'], '', '', '', 'vec', ''],
+    [['array_contains'], 'BOOLEAN', ['ARRAY_DECIMALV2', 'DECIMALV2'], '', '', '', 'vec', ''],
+    [['array_contains'], 'BOOLEAN', ['ARRAY_VARCHAR', 'VARCHAR'], '', '', '', 'vec', ''],
+    [['array_contains'], 'BOOLEAN', ['ARRAY_STRING', 'STRING'], '', '', '', 'vec', ''],
+
+    [['array_position'], 'BIGINT', ['ARRAY_TINYINT', 'TINYINT'], '', '', '', 'vec', ''],
+    [['array_position'], 'BIGINT', ['ARRAY_SMALLINT', 'SMALLINT'], '', '', '', 'vec', ''],
+    [['array_position'], 'BIGINT', ['ARRAY_INT', 'INT'], '', '', '', 'vec', ''],
+    [['array_position'], 'BIGINT', ['ARRAY_BIGINT', 'BIGINT'], '', '', '', 'vec', ''],
+    [['array_position'], 'BIGINT', ['ARRAY_LARGEINT', 'LARGEINT'], '', '', '', 'vec', ''],
+    [['array_position'], 'BIGINT', ['ARRAY_DATETIME', 'DATETIME'], '', '', '', 'vec', ''],
+    [['array_position'], 'BIGINT', ['ARRAY_DATE', 'DATE'], '', '', '', 'vec', ''],
+    [['array_position'], 'BIGINT', ['ARRAY_FLOAT', 'FLOAT'], '', '', '', 'vec', ''],
+    [['array_position'], 'BIGINT', ['ARRAY_DOUBLE', 'DOUBLE'], '', '', '', 'vec', ''],
+    [['array_position'], 'BIGINT', ['ARRAY_DECIMALV2', 'DECIMALV2'], '', '', '', 'vec', ''],

Review Comment:
   done
   
   element_at param type has changed to BIGINT, keep the same with the result type of array_position.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org