You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/22 19:09:20 UTC
[GitHub] [superset] gabester78 opened a new pull request #16794: style(update text for SLL Tooltip)
gabester78 opened a new pull request #16794:
URL: https://github.com/apache/superset/pull/16794
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Changed the SSL tooltip text to updated based on the database the user selects.
https://trello.com/c/B4i4wtpq/29-update-ssl-tooltip-text
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
<img width="1440" alt="Screen Shot 2021-09-22 at 12 49 32 PM" src="https://user-images.githubusercontent.com/48218164/134405197-6674713b-1b5b-4f5b-83f5-e3b94b43187f.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Unsure.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on a change in pull request #16794: style(update text for SLL Tooltip)
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on a change in pull request #16794:
URL: https://github.com/apache/superset/pull/16794#discussion_r714995083
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -454,13 +454,30 @@ const forceSSLField = ({
}}
/>
<span css={toggleStyle}>SSL</span>
- <InfoTooltip
- tooltip={t('SSL Mode "require" will be used.')}
- placement="right"
- viewBox="0 -5 24 24"
- />
+
+ {db?.database_name === 'PostgreSQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "require" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24"
+ /> )}
+
+ {db?.database_name === 'MySQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed).')}
+ placement="right"
+ viewBox="0 -5 24 24"
+ /> )}
+
+ {db?.database_name === 'Amazon Redshift' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "verify-ca" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24"
+ /> )}
+
</div>
-);
+ )
Review comment:
This parenthesis should have no tabbed space before it and a semicolon after it. Run the Prettify extension in VScode to catch these little things before GitHub CI does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] gabester78 commented on a change in pull request #16794: style(update text for SLL Tooltip)
Posted by GitBox <gi...@apache.org>.
gabester78 commented on a change in pull request #16794:
URL: https://github.com/apache/superset/pull/16794#discussion_r718799712
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -437,30 +437,45 @@ const forceSSLField = ({
changeMethods,
db,
sslForced,
-}: FieldPropTypes) => (
- <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
- <Switch
- disabled={sslForced && !isEditMode}
- checked={db?.parameters?.encryption || sslForced}
- onChange={changed => {
- changeMethods.onParametersChange({
- target: {
- type: 'toggle',
- name: 'encryption',
- checked: true,
- value: changed,
- },
- });
- }}
- />
- <span css={toggleStyle}>SSL</span>
- <InfoTooltip
- tooltip={t('SSL Mode "require" will be used.')}
- placement="right"
- viewBox="0 -5 24 24"
- />
- </div>
-);
+}: FieldPropTypes) => {
+ return (
+ <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
+ <Switch
+ disabled={sslForced && !isEditMode}
+ checked={db?.parameters?.encryption || sslForced}
+ onChange={changed => {
+ changeMethods.onParametersChange({
+ target: {
+ type: 'toggle',
+ name: 'encryption',
+ checked: true,
+ value: changed,
+ },
+ });
+ } } />
+ <span css={toggleStyle}>SSL</span>
+
+ {db?.database_name === 'PostgreSQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "require" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'MySQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed).')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'Amazon Redshift' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "verify-ca" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
Review comment:
Closing PR. Reference [here](https://github.com/apache/superset/pull/16907) for updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on a change in pull request #16794: style(update text for SLL Tooltip)
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on a change in pull request #16794:
URL: https://github.com/apache/superset/pull/16794#discussion_r714239981
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -437,7 +437,7 @@ const forceSSLField = ({
changeMethods,
db,
sslForced,
-}: FieldPropTypes) => (
+}: FieldPropTypes) => { console.log("db", db); return (
Review comment:
Remove the console.log and remove the curly brackets here, we won't need any js logic here now that we're done debugging 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] gabester78 closed pull request #16794: style(update text for SLL Tooltip)
Posted by GitBox <gi...@apache.org>.
gabester78 closed pull request #16794:
URL: https://github.com/apache/superset/pull/16794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] gabester78 commented on a change in pull request #16794: style(update text for SLL Tooltip)
Posted by GitBox <gi...@apache.org>.
gabester78 commented on a change in pull request #16794:
URL: https://github.com/apache/superset/pull/16794#discussion_r715798936
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -437,30 +437,45 @@ const forceSSLField = ({
changeMethods,
db,
sslForced,
-}: FieldPropTypes) => (
- <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
- <Switch
- disabled={sslForced && !isEditMode}
- checked={db?.parameters?.encryption || sslForced}
- onChange={changed => {
- changeMethods.onParametersChange({
- target: {
- type: 'toggle',
- name: 'encryption',
- checked: true,
- value: changed,
- },
- });
- }}
- />
- <span css={toggleStyle}>SSL</span>
- <InfoTooltip
- tooltip={t('SSL Mode "require" will be used.')}
- placement="right"
- viewBox="0 -5 24 24"
- />
- </div>
-);
+}: FieldPropTypes) => {
+ return (
+ <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
+ <Switch
+ disabled={sslForced && !isEditMode}
+ checked={db?.parameters?.encryption || sslForced}
+ onChange={changed => {
+ changeMethods.onParametersChange({
+ target: {
+ type: 'toggle',
+ name: 'encryption',
+ checked: true,
+ value: changed,
+ },
+ });
+ } } />
+ <span css={toggleStyle}>SSL</span>
+
+ {db?.database_name === 'PostgreSQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "require" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'MySQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed).')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'Amazon Redshift' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "verify-ca" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
Review comment:
Great thanks! Should I go ahead and make the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] gabester78 closed pull request #16794: style(update text for SLL Tooltip)
Posted by GitBox <gi...@apache.org>.
gabester78 closed pull request #16794:
URL: https://github.com/apache/superset/pull/16794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] gabester78 commented on a change in pull request #16794: style(update text for SLL Tooltip)
Posted by GitBox <gi...@apache.org>.
gabester78 commented on a change in pull request #16794:
URL: https://github.com/apache/superset/pull/16794#discussion_r718799712
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -437,30 +437,45 @@ const forceSSLField = ({
changeMethods,
db,
sslForced,
-}: FieldPropTypes) => (
- <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
- <Switch
- disabled={sslForced && !isEditMode}
- checked={db?.parameters?.encryption || sslForced}
- onChange={changed => {
- changeMethods.onParametersChange({
- target: {
- type: 'toggle',
- name: 'encryption',
- checked: true,
- value: changed,
- },
- });
- }}
- />
- <span css={toggleStyle}>SSL</span>
- <InfoTooltip
- tooltip={t('SSL Mode "require" will be used.')}
- placement="right"
- viewBox="0 -5 24 24"
- />
- </div>
-);
+}: FieldPropTypes) => {
+ return (
+ <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
+ <Switch
+ disabled={sslForced && !isEditMode}
+ checked={db?.parameters?.encryption || sslForced}
+ onChange={changed => {
+ changeMethods.onParametersChange({
+ target: {
+ type: 'toggle',
+ name: 'encryption',
+ checked: true,
+ value: changed,
+ },
+ });
+ } } />
+ <span css={toggleStyle}>SSL</span>
+
+ {db?.database_name === 'PostgreSQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "require" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'MySQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed).')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'Amazon Redshift' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "verify-ca" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
Review comment:
Closing PR. Reference [](https://github.com/apache/superset/pull/16907) for updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #16794: style(update text for SLL Tooltip)
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #16794:
URL: https://github.com/apache/superset/pull/16794#discussion_r715790879
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -437,30 +437,45 @@ const forceSSLField = ({
changeMethods,
db,
sslForced,
-}: FieldPropTypes) => (
- <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
- <Switch
- disabled={sslForced && !isEditMode}
- checked={db?.parameters?.encryption || sslForced}
- onChange={changed => {
- changeMethods.onParametersChange({
- target: {
- type: 'toggle',
- name: 'encryption',
- checked: true,
- value: changed,
- },
- });
- }}
- />
- <span css={toggleStyle}>SSL</span>
- <InfoTooltip
- tooltip={t('SSL Mode "require" will be used.')}
- placement="right"
- viewBox="0 -5 24 24"
- />
- </div>
-);
+}: FieldPropTypes) => {
+ return (
+ <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
+ <Switch
+ disabled={sslForced && !isEditMode}
+ checked={db?.parameters?.encryption || sslForced}
+ onChange={changed => {
+ changeMethods.onParametersChange({
+ target: {
+ type: 'toggle',
+ name: 'encryption',
+ checked: true,
+ value: changed,
+ },
+ });
+ } } />
+ <span css={toggleStyle}>SSL</span>
+
+ {db?.database_name === 'PostgreSQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "require" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'MySQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed).')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'Amazon Redshift' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "verify-ca" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
Review comment:
Thanks for this @gabester78! One suggestion that could make this database type agnostic and also clean up the three different InfoTooltips here would be to
1) use an object for getting the different text, so something like:
```
const tooltipText = {
foo: "some text",
bar: "other text",
}
```
and then
```
<InfoTooltip
tooltip={t(tooltipText(somevariable))}
placement="right"
viewBox="0 -5 24 24" />)}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #16794: style(update text for SLL Tooltip)
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #16794:
URL: https://github.com/apache/superset/pull/16794#discussion_r715794682
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -437,30 +437,45 @@ const forceSSLField = ({
changeMethods,
db,
sslForced,
-}: FieldPropTypes) => (
- <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
- <Switch
- disabled={sslForced && !isEditMode}
- checked={db?.parameters?.encryption || sslForced}
- onChange={changed => {
- changeMethods.onParametersChange({
- target: {
- type: 'toggle',
- name: 'encryption',
- checked: true,
- value: changed,
- },
- });
- }}
- />
- <span css={toggleStyle}>SSL</span>
- <InfoTooltip
- tooltip={t('SSL Mode "require" will be used.')}
- placement="right"
- viewBox="0 -5 24 24"
- />
- </div>
-);
+}: FieldPropTypes) => {
+ return (
+ <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
+ <Switch
+ disabled={sslForced && !isEditMode}
+ checked={db?.parameters?.encryption || sslForced}
+ onChange={changed => {
+ changeMethods.onParametersChange({
+ target: {
+ type: 'toggle',
+ name: 'encryption',
+ checked: true,
+ value: changed,
+ },
+ });
+ } } />
+ <span css={toggleStyle}>SSL</span>
+
+ {db?.database_name === 'PostgreSQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "require" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'MySQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed).')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'Amazon Redshift' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "verify-ca" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
Review comment:
2. you should be able to use the db.encryption_params.sslmode to switch between the different types of text, so you would pass the key in like `tooltip={t(tooltipText(db.encryption_params.sslmode))}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] gabester78 commented on pull request #16794: style(update text for SLL Tooltip)
Posted by GitBox <gi...@apache.org>.
gabester78 commented on pull request #16794:
URL: https://github.com/apache/superset/pull/16794#issuecomment-930456894
Continuing work at this [PR](https://github.com/apache/superset/pull/16907)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] gabester78 commented on pull request #16794: style(update text for SLL Tooltip)
Posted by GitBox <gi...@apache.org>.
gabester78 commented on pull request #16794:
URL: https://github.com/apache/superset/pull/16794#issuecomment-930456894
Continuing work at this [PR](https://github.com/apache/superset/pull/16907)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] gabester78 commented on a change in pull request #16794: style(update text for SLL Tooltip)
Posted by GitBox <gi...@apache.org>.
gabester78 commented on a change in pull request #16794:
URL: https://github.com/apache/superset/pull/16794#discussion_r718799712
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -437,30 +437,45 @@ const forceSSLField = ({
changeMethods,
db,
sslForced,
-}: FieldPropTypes) => (
- <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
- <Switch
- disabled={sslForced && !isEditMode}
- checked={db?.parameters?.encryption || sslForced}
- onChange={changed => {
- changeMethods.onParametersChange({
- target: {
- type: 'toggle',
- name: 'encryption',
- checked: true,
- value: changed,
- },
- });
- }}
- />
- <span css={toggleStyle}>SSL</span>
- <InfoTooltip
- tooltip={t('SSL Mode "require" will be used.')}
- placement="right"
- viewBox="0 -5 24 24"
- />
- </div>
-);
+}: FieldPropTypes) => {
+ return (
+ <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
+ <Switch
+ disabled={sslForced && !isEditMode}
+ checked={db?.parameters?.encryption || sslForced}
+ onChange={changed => {
+ changeMethods.onParametersChange({
+ target: {
+ type: 'toggle',
+ name: 'encryption',
+ checked: true,
+ value: changed,
+ },
+ });
+ } } />
+ <span css={toggleStyle}>SSL</span>
+
+ {db?.database_name === 'PostgreSQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "require" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'MySQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed).')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'Amazon Redshift' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "verify-ca" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
Review comment:
Closing PR. Reference [](https://github.com/apache/superset/pull/16907) for updates.
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -437,30 +437,45 @@ const forceSSLField = ({
changeMethods,
db,
sslForced,
-}: FieldPropTypes) => (
- <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
- <Switch
- disabled={sslForced && !isEditMode}
- checked={db?.parameters?.encryption || sslForced}
- onChange={changed => {
- changeMethods.onParametersChange({
- target: {
- type: 'toggle',
- name: 'encryption',
- checked: true,
- value: changed,
- },
- });
- }}
- />
- <span css={toggleStyle}>SSL</span>
- <InfoTooltip
- tooltip={t('SSL Mode "require" will be used.')}
- placement="right"
- viewBox="0 -5 24 24"
- />
- </div>
-);
+}: FieldPropTypes) => {
+ return (
+ <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
+ <Switch
+ disabled={sslForced && !isEditMode}
+ checked={db?.parameters?.encryption || sslForced}
+ onChange={changed => {
+ changeMethods.onParametersChange({
+ target: {
+ type: 'toggle',
+ name: 'encryption',
+ checked: true,
+ value: changed,
+ },
+ });
+ } } />
+ <span css={toggleStyle}>SSL</span>
+
+ {db?.database_name === 'PostgreSQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "require" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'MySQL' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed).')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
+ {db?.database_name === 'Amazon Redshift' && (
+ <InfoTooltip
+ tooltip={t('Requires a root certificate authority (public, local, or self-signed). SSL Mode "verify-ca" will be used.')}
+ placement="right"
+ viewBox="0 -5 24 24" />)}
+
Review comment:
Closing PR. Reference [here](https://github.com/apache/superset/pull/16907) for updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org