You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/06 08:13:26 UTC
[GitHub] [flink] rudikershaw opened a new pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.
rudikershaw opened a new pull request #17417:
URL: https://github.com/apache/flink/pull/17417
# Draft PR - Not Ready for Review
## What is the purpose of the change
The EFO Kinesis connector will register and de-register stream consumers based on the [configured registration strategy](https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/connectors/datastream/kinesis/#efo-stream-consumer-registrationderegistration). When EAGER is used, the client (usually job manager) will register the consumer and then the task managers will de-register the consumer when job stops/fails. If the job is configured to restart on fail, then the consumer will not exist and the job will continuously fail over.
After this change the connector will not trigger consumer reregistration in EFO if using the EAGER registration strategy. This will allow EAGER EFO configured connector applications to use restart policies without continuously failing. The documentation is updated accordingly.
## Brief change log
- *Add dedicated utility function for determining whether consumer reregistration is required.*
- *Ensure consumer deregistration now only occurs when EFO is configured using the LAZY registration strategy.*
- (TODO) *Update the documentation to reflect the changes*
## Verifying this change
*(Please pick either of the following options)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): No
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: No
- The serializers: No
- The runtime per-record code paths (performance sensitive): No
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: Yes
- The S3 file system connector: No
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 [flink-connector-kinesis] Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793",
"triggerID" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"triggerType" : "PUSH"
}, {
"hash" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24797",
"triggerID" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"triggerType" : "PUSH"
}, {
"hash" : "2f40d474e8ed29e4754cb6da0567f5443110f63d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f40d474e8ed29e4754cb6da0567f5443110f63d",
"triggerType" : "PUSH"
}, {
"hash" : "c927b47bfa5c357b49ba0404077823ade9ca123e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24799",
"triggerID" : "c927b47bfa5c357b49ba0404077823ade9ca123e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2f40d474e8ed29e4754cb6da0567f5443110f63d UNKNOWN
* c927b47bfa5c357b49ba0404077823ade9ca123e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24799)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793",
"triggerID" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"triggerType" : "PUSH"
}, {
"hash" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24797",
"triggerID" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ab98b74160adc6c2508b77bbb3b1380acf69567 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793)
* 7a79e744ab5ca7b50cf913f453c871e6f2c07f00 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24797)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793",
"triggerID" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"triggerType" : "PUSH"
}, {
"hash" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ab98b74160adc6c2508b77bbb3b1380acf69567 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793)
* 7a79e744ab5ca7b50cf913f453c871e6f2c07f00 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793",
"triggerID" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"triggerType" : "PUSH"
}, {
"hash" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24797",
"triggerID" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"triggerType" : "PUSH"
}, {
"hash" : "2f40d474e8ed29e4754cb6da0567f5443110f63d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f40d474e8ed29e4754cb6da0567f5443110f63d",
"triggerType" : "PUSH"
}, {
"hash" : "c927b47bfa5c357b49ba0404077823ade9ca123e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24799",
"triggerID" : "c927b47bfa5c357b49ba0404077823ade9ca123e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a79e744ab5ca7b50cf913f453c871e6f2c07f00 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24797)
* 2f40d474e8ed29e4754cb6da0567f5443110f63d UNKNOWN
* c927b47bfa5c357b49ba0404077823ade9ca123e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24799)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 [flink-connector-kinesis] Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793",
"triggerID" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"triggerType" : "PUSH"
}, {
"hash" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24797",
"triggerID" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"triggerType" : "PUSH"
}, {
"hash" : "2f40d474e8ed29e4754cb6da0567f5443110f63d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f40d474e8ed29e4754cb6da0567f5443110f63d",
"triggerType" : "PUSH"
}, {
"hash" : "c927b47bfa5c357b49ba0404077823ade9ca123e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24799",
"triggerID" : "c927b47bfa5c357b49ba0404077823ade9ca123e",
"triggerType" : "PUSH"
}, {
"hash" : "3c211606b3465a1e719bc1a8f70caa620edc0984",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3c211606b3465a1e719bc1a8f70caa620edc0984",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2f40d474e8ed29e4754cb6da0567f5443110f63d UNKNOWN
* c927b47bfa5c357b49ba0404077823ade9ca123e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24799)
* 3c211606b3465a1e719bc1a8f70caa620edc0984 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #17417: FLINK-24431 [flink-connector-kinesis] Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-937674900
@rudikershaw thanks for the contribution, can you also update the `cn` documentation? It is still in English but eventually someone will translate it: https://github.com/apache/flink/blob/master/docs/content.zh/docs/connectors/datastream/kinesis.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rudikershaw commented on pull request #17417: FLINK-24431 [flink-connector-kinesis] Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
rudikershaw commented on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-936438843
Build is passing and documentation has been updated. Marking as `Ready for review`.
FYI @flinkbot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793",
"triggerID" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"triggerType" : "PUSH"
}, {
"hash" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24797",
"triggerID" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"triggerType" : "PUSH"
}, {
"hash" : "2f40d474e8ed29e4754cb6da0567f5443110f63d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f40d474e8ed29e4754cb6da0567f5443110f63d",
"triggerType" : "PUSH"
}, {
"hash" : "c927b47bfa5c357b49ba0404077823ade9ca123e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c927b47bfa5c357b49ba0404077823ade9ca123e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ab98b74160adc6c2508b77bbb3b1380acf69567 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793)
* 7a79e744ab5ca7b50cf913f453c871e6f2c07f00 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24797)
* 2f40d474e8ed29e4754cb6da0567f5443110f63d UNKNOWN
* c927b47bfa5c357b49ba0404077823ade9ca123e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer merged pull request #17417: FLINK-24431 [flink-connector-kinesis] Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
dannycranmer merged pull request #17417:
URL: https://github.com/apache/flink/pull/17417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 [flink-connector-kinesis] Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793",
"triggerID" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"triggerType" : "PUSH"
}, {
"hash" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24797",
"triggerID" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"triggerType" : "PUSH"
}, {
"hash" : "2f40d474e8ed29e4754cb6da0567f5443110f63d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f40d474e8ed29e4754cb6da0567f5443110f63d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ab98b74160adc6c2508b77bbb3b1380acf69567 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793)
* 7a79e744ab5ca7b50cf913f453c871e6f2c07f00 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24797)
* 2f40d474e8ed29e4754cb6da0567f5443110f63d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793",
"triggerID" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ab98b74160adc6c2508b77bbb3b1380acf69567 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ab98b74160adc6c2508b77bbb3b1380acf69567 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17417: FLINK-24431 [flink-connector-kinesis] Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-935782208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24793",
"triggerID" : "8ab98b74160adc6c2508b77bbb3b1380acf69567",
"triggerType" : "PUSH"
}, {
"hash" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24797",
"triggerID" : "7a79e744ab5ca7b50cf913f453c871e6f2c07f00",
"triggerType" : "PUSH"
}, {
"hash" : "2f40d474e8ed29e4754cb6da0567f5443110f63d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f40d474e8ed29e4754cb6da0567f5443110f63d",
"triggerType" : "PUSH"
}, {
"hash" : "c927b47bfa5c357b49ba0404077823ade9ca123e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24799",
"triggerID" : "c927b47bfa5c357b49ba0404077823ade9ca123e",
"triggerType" : "PUSH"
}, {
"hash" : "3c211606b3465a1e719bc1a8f70caa620edc0984",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24819",
"triggerID" : "3c211606b3465a1e719bc1a8f70caa620edc0984",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2f40d474e8ed29e4754cb6da0567f5443110f63d UNKNOWN
* c927b47bfa5c357b49ba0404077823ade9ca123e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24799)
* 3c211606b3465a1e719bc1a8f70caa620edc0984 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24819)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer merged pull request #17417: FLINK-24431 [flink-connector-kinesis] Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
dannycranmer merged pull request #17417:
URL: https://github.com/apache/flink/pull/17417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #17417: FLINK-24431 [flink-connector-kinesis] Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-937674900
@rudikershaw thanks for the contribution, can you also update the `cn` documentation? It is still in English but eventually someone will translate it: https://github.com/apache/flink/blob/master/docs/content.zh/docs/connectors/datastream/kinesis.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17417: FLINK-24431 Stop consumer deregistration when EAGER EFO configured.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17417:
URL: https://github.com/apache/flink/pull/17417#issuecomment-935722614
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8ab98b74160adc6c2508b77bbb3b1380acf69567 (Wed Oct 06 08:16:59 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org