You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/04 13:18:34 UTC

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7024: server: correctly list suitable hosts for migration with uefi capability

weizhouapache commented on code in PR #7024:
URL: https://github.com/apache/cloudstack/pull/7024#discussion_r1061473288


##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -823,7 +826,7 @@ public class ManagementServerImpl extends ManagerBase implements ManagementServe
     @Inject
     private HostDao _hostDao;
     @Inject
-    private HostDetailsDao _detailsDao;
+    protected HostDetailsDao _detailsDao;

Review Comment:
   @shwstppr 
   I think it is better to rename it to _hostDetailsDao



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org