You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by yamane-dsys <gi...@git.apache.org> on 2016/11/30 06:14:13 UTC
[GitHub] cordova-plugin-device pull request #58: CB-12199: (android) Add SDK version ...
GitHub user yamane-dsys opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/58
CB-12199: (android) Add SDK version property for Android
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Add device.sdkversion property.
### What testing has been done on this change?
Add AutoTest for sdkversion to 'tests/tests.js'
Done AutoTests and ManualTests with cordova-plugin-test-framework
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yamane-dsys/cordova-plugin-device master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit ab595695e57bd9a8bde8132f5d210424f3439c8c
Author: YAMANE Takaaki <ya...@dsystems.co.jp>
Date: 2016-11-24T09:49:55Z
Use SDK_INT value for Android sdkversion, instead of SDK
(which was deprecated in API level 4)
commit 3634cad8a3ee60c91d76e48a1ef5cd4732cbd8d0
Author: YAMANE Takaaki <ya...@dsystems.co.jp>
Date: 2016-11-24T09:54:08Z
Add property device.sdkversion (Android)
commit ef9d50ef50ba7e26a40c93a5fe0a78287b6bae11
Author: YAMANE Takaaki <ya...@dsystems.co.jp>
Date: 2016-11-30T05:10:44Z
Add AutoTest for "sdkversion"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device issue #58: CB-12199: (android) Add SDK version propert...
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/58
Cordova CI Build has completed successfully.
**Commit** - [Link](https://github.com/apache/cordova-plugin-device/pull/58/commits/ef9d50ef50ba7e26a40c93a5fe0a78287b6bae11)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19/)
| Builder Name | Console Output | Test Report | Device Logs |
| :---: | :---: | :---: | :---: |
| [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-store/artifact/) |
| [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-10-store/artifact/) |
| [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=windows-8.1-phone/artifact/) |
| [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=ios/artifact/) |
| [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-pr/19//PLATFORM=android/artifact/) |
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request #58: CB-12199: (android) Add SDK version ...
Posted by yamane-dsys <gi...@git.apache.org>.
Github user yamane-dsys closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device issue #58: CB-12199: (android) Add SDK version propert...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/58
hey @yamane-dsys!
Your PR is in great shape. I appreciate you adding tests too!
Unfortunately, I don't think I can accept this PR. We only add new properties to device if it can be implemented across all of our platforms.
I'm curious what your use-case for this is?
You should think about creating a plugin for this specific use-case yourself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org