[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1777: [feature] #1452 support "hive.aux.jars.path" for hive engine

[GitBox <gi...@apache.org>]

peacewong commented on a change in pull request #1777:
URL: https://github.com/apache/incubator-linkis/pull/1777#discussion_r832067687



##########
File path: linkis-engineconn-plugins/engineconn-plugins/hive/src/main/scala/org/apache/linkis/engineplugin/hive/creation/HiveEngineConnFactory.scala
##########
@@ -69,6 +69,11 @@ class HiveEngineConnFactory extends ComputationSingleExecutorEngineConnFactory w
       hiveConf.setVar(HiveConf.ConfVars.HIVEFETCHOUTPUTSERDE, HiveEngineConfiguration.BASE64_SERDE_CLASS)
       hiveConf.set("enable_fetch_base64","true")
     }
+    //add hive.aux.jars.path to hive conf
+    if(StringUtils.isNotEmpty(HiveEngineConfiguration.HIVE_AUX_JARS_PATH)) {

Review comment:
       Is it better to use isNotBlank here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org