You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/11 19:15:02 UTC

[GitHub] merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-357031277
 
 
   @sschepens Thanks for investigating this and finding the root cause! 
   One other option to fix this was to get rid of the `DoubleByteBuf` alltogether. Maybe just keep it as a "holder" of the 2 buffers, but writing directly the 2 buffers to the channel rather than writing the `DoubleByteBuf`. This should be more efficient since we don't have to create the array of `ByteBuffers`. 
   
   What do you think? Would you want do that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services