You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/18 10:31:54 UTC
[GitHub] [netbeans] JaroslavTulach opened a new pull request #2685: Don't show reload/save dialogs in VSNetBeans
JaroslavTulach opened a new pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685
VS Code manages files itself. Rename, copy, delete is handled by their UI and only later notified to the NetBeans backend. This PR provides branding API (not yet documented), to disable showing dialogs to the user and provide a default answer. This approach builds on previous branding API like #2427, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r561939287
##########
File path: java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar/org/netbeans/modules/openide/loaders/Bundle.properties
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# yes/no/ask
+ASK_OnSaving=no
+# yes/no/ask
+ASK_OnClosing=no
Review comment:
Right. I did check `java/java.lsp.server/nbcode/integration/nbproject/project.xml` and there is no dependency on `org.openide.loaders`. I can add one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r561974176
##########
File path: platform/openide.loaders/arch.xml
##########
@@ -542,6 +542,21 @@ for more information about this.
underlaying <a href="@TOP@/architecture-summary.html#script">scripting and templating
engines</a>.
</api>
+
+ <api name="ASK_OnSaving" group="branding" type="export" category="stable">
Review comment:
Fixed globally in 1ee8dfee3601
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r560899603
##########
File path: java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar/org/netbeans/modules/openide/loaders/Bundle.properties
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# yes/no/ask
+ASK_OnSaving=no
+# yes/no/ask
+ASK_OnClosing=no
Review comment:
Right. I did check `java/java.lsp.server/nbcode/integration/nbproject/project.xml` and there is no dependency on `org.openide.loaders`. I can add one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r560896770
##########
File path: platform/openide.loaders/src/org/openide/text/DataEditorSupport.java
##########
@@ -1353,19 +1331,8 @@ public void run() throws IOException {
try {
des.superSaveDoc();
} catch (UserQuestionException ex) {
- if (GraphicsEnvironment.isHeadless()) {
Review comment:
I'm opting for declaring the change as an incompatible change in this case. The previous change was neither documented or tested and it is there just a three months...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r561971604
##########
File path: java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar/org/netbeans/modules/openide/loaders/Bundle.properties
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# yes/no/ask
+ASK_OnSaving=no
+# yes/no/ask
+ASK_OnClosing=no
Review comment:
Fixed in cc1eb58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r561939287
##########
File path: java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar/org/netbeans/modules/openide/loaders/Bundle.properties
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# yes/no/ask
+ASK_OnSaving=no
+# yes/no/ask
+ASK_OnClosing=no
Review comment:
Right. I did check `java/java.lsp.server/nbcode/integration/nbproject/project.xml` and there is no dependency on `org.openide.loaders`. I can add one.
##########
File path: platform/openide.loaders/src/org/openide/text/DataEditorSupport.java
##########
@@ -1353,19 +1331,8 @@ public void run() throws IOException {
try {
des.superSaveDoc();
} catch (UserQuestionException ex) {
- if (GraphicsEnvironment.isHeadless()) {
Review comment:
Done in 4f42da8398.
##########
File path: platform/openide.loaders/arch.xml
##########
@@ -542,6 +542,21 @@ for more information about this.
underlaying <a href="@TOP@/architecture-summary.html#script">scripting and templating
engines</a>.
</api>
+
+ <api name="ASK_OnSaving" group="branding" type="export" category="stable">
Review comment:
Looking at [list of branding APIs](https://bits.netbeans.org/dev/javadoc/branding.html), it seems there used to be some convention. For example the `org.netbeans.core.netigso.FRAMEWORK_START_LEVEL` key & similar seem to spell out the package name of the bundle first and then some further info.
I can follow that convention in this PR too.
##########
File path: java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar/org/netbeans/modules/openide/loaders/Bundle.properties
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# yes/no/ask
+ASK_OnSaving=no
+# yes/no/ask
+ASK_OnClosing=no
Review comment:
Fixed in cc1eb58196680
##########
File path: platform/openide.loaders/arch.xml
##########
@@ -542,6 +542,21 @@ for more information about this.
underlaying <a href="@TOP@/architecture-summary.html#script">scripting and templating
engines</a>.
</api>
+
+ <api name="ASK_OnSaving" group="branding" type="export" category="stable">
Review comment:
Fixed globally in 1ee8dfee3601
##########
File path: platform/openide.loaders/src/org/openide/text/DataEditorSupport.java
##########
@@ -1353,19 +1331,8 @@ public void run() throws IOException {
try {
des.superSaveDoc();
} catch (UserQuestionException ex) {
- if (GraphicsEnvironment.isHeadless()) {
Review comment:
Done in 4f42da8.
##########
File path: platform/openide.loaders/arch.xml
##########
@@ -542,6 +542,21 @@ for more information about this.
underlaying <a href="@TOP@/architecture-summary.html#script">scripting and templating
engines</a>.
</api>
+
+ <api name="ASK_OnSaving" group="branding" type="export" category="stable">
Review comment:
Fixed globally in 1ee8dfe
##########
File path: java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar/org/netbeans/modules/openide/loaders/Bundle.properties
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# yes/no/ask
+ASK_OnSaving=no
+# yes/no/ask
+ASK_OnClosing=no
Review comment:
Fixed in cc1eb58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r560895910
##########
File path: platform/openide.loaders/arch.xml
##########
@@ -542,6 +542,21 @@ for more information about this.
underlaying <a href="@TOP@/architecture-summary.html#script">scripting and templating
engines</a>.
</api>
+
+ <api name="ASK_OnSaving" group="branding" type="export" category="stable">
Review comment:
Looking at [list of branding APIs](https://bits.netbeans.org/dev/javadoc/branding.html), it seems there used to be some convention. For example the `org.netbeans.core.netigso.FRAMEWORK_START_LEVEL` key & similar seem to spell out the package name of the bundle first and then some further info.
I can follow that convention in this PR too. Fixing others may be better for some another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach merged pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach merged pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r560896770
##########
File path: platform/openide.loaders/src/org/openide/text/DataEditorSupport.java
##########
@@ -1353,19 +1331,8 @@ public void run() throws IOException {
try {
des.superSaveDoc();
} catch (UserQuestionException ex) {
- if (GraphicsEnvironment.isHeadless()) {
Review comment:
I'm opting for declaring the change as an incompatible change in this case. The previous usage of `isHeadless()` was neither documented nor tested and it is there just for three months...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r560042627
##########
File path: platform/openide.loaders/src/org/openide/text/DataEditorSupport.java
##########
@@ -1353,19 +1331,8 @@ public void run() throws IOException {
try {
des.superSaveDoc();
} catch (UserQuestionException ex) {
- if (GraphicsEnvironment.isHeadless()) {
Review comment:
This check has been added by Martin Entlicher half a year ago, before it become possible to show `NotifyDescriptor` dialogs in VSCode. Now the dialog could be shown (but we don't want it anyway). As such I am removing the headless check and replacing it with a branding API that allows `java/java.lsp.server/nbcode` suite to explicitly say 'no'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r561974176
##########
File path: platform/openide.loaders/arch.xml
##########
@@ -542,6 +542,21 @@ for more information about this.
underlaying <a href="@TOP@/architecture-summary.html#script">scripting and templating
engines</a>.
</api>
+
+ <api name="ASK_OnSaving" group="branding" type="export" category="stable">
Review comment:
Fixed globally in 1ee8dfe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r560873595
##########
File path: java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar/org/netbeans/modules/openide/loaders/Bundle.properties
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# yes/no/ask
+ASK_OnSaving=no
+# yes/no/ask
+ASK_OnClosing=no
Review comment:
Q: shouldn't be there some dependency on loaders >= 1.80 ?
##########
File path: platform/openide.loaders/arch.xml
##########
@@ -542,6 +542,21 @@ for more information about this.
underlaying <a href="@TOP@/architecture-summary.html#script">scripting and templating
engines</a>.
</api>
+
+ <api name="ASK_OnSaving" group="branding" type="export" category="stable">
Review comment:
Isuggest to establish some policy or naming convention on these functional resource bundle keys. Maybe a separate Bundle should be always used, but either the bundle or the API keys should be named so that everyone knows that moving the keys to another bundle, renaming the keys, or change of usage is a BIG no-no.
##########
File path: platform/openide.loaders/src/org/openide/text/DataEditorSupport.java
##########
@@ -1353,19 +1331,8 @@ public void run() throws IOException {
try {
des.superSaveDoc();
} catch (UserQuestionException ex) {
- if (GraphicsEnvironment.isHeadless()) {
Review comment:
Note that this code was released with 12.2; IMHO in headless environment the code should default to 'yes' setting to remain compatible. Otherwise declare an incompatible change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r561945454
##########
File path: platform/openide.loaders/src/org/openide/text/DataEditorSupport.java
##########
@@ -1353,19 +1331,8 @@ public void run() throws IOException {
try {
des.superSaveDoc();
} catch (UserQuestionException ex) {
- if (GraphicsEnvironment.isHeadless()) {
Review comment:
Done in 4f42da8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r560895910
##########
File path: platform/openide.loaders/arch.xml
##########
@@ -542,6 +542,21 @@ for more information about this.
underlaying <a href="@TOP@/architecture-summary.html#script">scripting and templating
engines</a>.
</api>
+
+ <api name="ASK_OnSaving" group="branding" type="export" category="stable">
Review comment:
Looking at [list of branding APIs](https://bits.netbeans.org/dev/javadoc/branding.html), it seems there used to be some convention. For example the `org.netbeans.core.netigso.FRAMEWORK_START_LEVEL` key & similar seem to spell out the package name of the bundle first and then some further info.
I can follow that convention in this PR too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach merged pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach merged pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r561945454
##########
File path: platform/openide.loaders/src/org/openide/text/DataEditorSupport.java
##########
@@ -1353,19 +1331,8 @@ public void run() throws IOException {
try {
des.superSaveDoc();
} catch (UserQuestionException ex) {
- if (GraphicsEnvironment.isHeadless()) {
Review comment:
Done in 4f42da8398.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r560896770
##########
File path: platform/openide.loaders/src/org/openide/text/DataEditorSupport.java
##########
@@ -1353,19 +1331,8 @@ public void run() throws IOException {
try {
des.superSaveDoc();
} catch (UserQuestionException ex) {
- if (GraphicsEnvironment.isHeadless()) {
Review comment:
I'm opting for declaring the change as an incompatible change in this case. The previous usage of `isHeadless()` was neither documented or tested and it is there just a three months...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2685: Don't show reload/save dialogs in VSNetBeans
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r561971604
##########
File path: java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar/org/netbeans/modules/openide/loaders/Bundle.properties
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# yes/no/ask
+ASK_OnSaving=no
+# yes/no/ask
+ASK_OnClosing=no
Review comment:
Fixed in cc1eb58196680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists