You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2010/10/20 22:26:23 UTC

[jira] Commented: (WICKET-3119) Localizer cache does not include style in cache key when no component is given

    [ https://issues.apache.org/jira/browse/WICKET-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923155#action_12923155 ] 

Hudson commented on WICKET-3119:
--------------------------------

Integrated in Apache Wicket 1.5.x #427 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/427/])
    Issue: WICKET-3119


> Localizer cache does not include style in cache key when no component is given
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-3119
>                 URL: https://issues.apache.org/jira/browse/WICKET-3119
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Nick Wiedenbrueck
>            Assignee: Igor Vaynberg
>             Fix For: 1.4.13, 1.5-M3
>
>         Attachments: localizer.patch
>
>
> Localizer uses a cache internally to cache the results of getString() methods. The getCacheKey() method creates the key for the cache entries:
> getCacheKey(final String key, final Component component, final Locale locale, final String style, final String variation)
> When a null component is given, this method creates a cache key from the key param and the locale param, but does not include the style param. When switching between styles, this leads to unexpected behavior.
> I'll attach a patch with test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.