[GitHub] [spark] cloud-fan commented on a change in pull request #31152: [SPARK-34089][CORE] HybridRowQueue should respect the configured memory mode

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31152:
URL: https://github.com/apache/spark/pull/31152#discussion_r595787267



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/RowQueue.scala
##########
@@ -174,7 +174,8 @@ private[python] case class HybridRowQueue(
     tempDir: File,
     numFields: Int,
     serMgr: SerializerManager)
-  extends MemoryConsumer(memManager) with RowQueue {
+  extends MemoryConsumer(memManager, memManager.pageSizeBytes(), memManager.getTungstenMemoryMode)

Review comment:
       The question is which should be the default in `MemoryConsumer` constructor. Should the default be always using ON_HEAP mode? Or depending on the config?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org