You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/12/29 08:37:14 UTC

[GitHub] [zeppelin] jongyoul opened a new pull request, #4541: [MINOR] Support aarch for frontend plugin

jongyoul opened a new pull request, #4541:
URL: https://github.com/apache/zeppelin/pull/4541

   ### What is this PR for?
   Fixing build error when using aarch jdk for mac OS. our version of node doesn't support amd64 arch but the old plugin tries to download arm version.
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [x] - Update `frontend-maven-plugin`
   
   ### What is the Jira issue?
   N/A
   
   ### How should this be tested?
   * Pass to build with arm jdk in macOS
   
   ### Screenshots (if appropriate)
   <img width="977" alt="image" src="https://user-images.githubusercontent.com/3612566/209925519-a52c9d0a-289c-48a9-91b9-0837687736c6.png">
   
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No 
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] huage1994 commented on pull request #4541: [MINOR] Support aarch for frontend plugin

Posted by GitBox <gi...@apache.org>.
huage1994 commented on PR #4541:
URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1368399071

   It looks good to me 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] pan3793 commented on pull request #4541: [MINOR] Support aarch for frontend plugin

Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4541:
URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1373491658

   I roughly remember that NodeJS officially supported Apple Silicon in v16(actually in v15, but it's not an LTS, and was EOL), and eventually, they decided to port this feature to v14 but does not publish the binary artifacts.
   
   So I suppose upgrading NodeJS v16 is necessary.
   
   Sorry I can not take this because I don't have much knowledge in frontend stacks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jongyoul commented on pull request #4541: [MINOR] Support aarch for frontend plugin

Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4541:
URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1374326089

   Thank you for the description. I also checked it and found the latest version is supporting that way. In our current version, the plugin tries to add suffix for arm64 to download proper node binary but in the latest version, it checks if the our node version is below 16 or not. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jongyoul commented on pull request #4541: [MINOR] Support aarch for frontend plugin

Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4541:
URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1376759595

   @Reamer The CI becomes back as the previous so it's ok. Could you please recheck it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jongyoul commented on pull request #4541: [MINOR] Support aarch for frontend plugin

Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4541:
URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1367157024

   BTW, as mentioned in #4523, The compilation time becomes faster if we use arm jdk in m1 mac


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jongyoul commented on pull request #4541: [MINOR] Support aarch for frontend plugin

Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4541:
URL: https://github.com/apache/zeppelin/pull/4541#issuecomment-1368420571

   @huage1994 Thank you. BTW, it has a dependency issue. It's related to Helium feature because it uses frontend-core to download npm package for custom visualization feature. I think we'd better reinvent the Helium with minimum but it's a problem anyway. I'll fix it and let you know. Please review it again after fixing the issue.
   
   ```
   Dependency convergence error for com.fasterxml.jackson.core:jackson-core:2.13.0 paths to dependency are:
   +-org.apache.zeppelin:zeppelin-interpreter-integration:0.11.0-SNAPSHOT
     +-org.apache.zeppelin:zeppelin-zengine:0.11.0-SNAPSHOT
       +-com.github.eirslett:frontend-plugin-core:1.12.1
         +-com.fasterxml.jackson.core:jackson-core:2.13.0
   and
   +-org.apache.zeppelin:zeppelin-interpreter-integration:0.11.0-SNAPSHOT
     +-org.apache.zeppelin:zeppelin-server:0.11.0-SNAPSHOT
       +-com.fasterxml.jackson.core:jackson-databind:2.12.6.1
         +-com.fasterxml.jackson.core:jackson-core:2.12.6
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jongyoul merged pull request #4541: [MINOR] Support aarch for frontend plugin

Posted by GitBox <gi...@apache.org>.
jongyoul merged PR #4541:
URL: https://github.com/apache/zeppelin/pull/4541


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org