You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/19 03:21:39 UTC

[GitHub] xccui commented on issue #6874: [FLINK-8483][DataStream] Implement and expose outer joins

xccui commented on issue #6874: [FLINK-8483][DataStream] Implement and expose outer joins
URL: https://github.com/apache/flink/pull/6874#issuecomment-431232789
 
 
   
   Hi @florianschmidt1994 , thanks for working on this!
   
   Before looking into the code, I'd like to share two thoughts.
   
   1. I think there's no need to register a clean-up timer for each record. In [TimeBoundedJoin](https://github.com/apache/flink/blob/master/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamJoin.scala), only the first timer is registered in the `processElement()` method and following timers are registered in a "chained manner" after each cleaning-up.
   
   2. Without holding back watermarks, the join results in the downstream operators may be taken as outdated (according to the different mechanisms for rowtime propagation), which makes the join operation less applicable. What do you think?
   
   Best, Xingcan

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services