You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/06/02 10:16:27 UTC
[GitHub] [echarts] Ovilia opened a new pull request #15072: fix(endLabel): endLabel should be displayed if show is true
Ovilia opened a new pull request #15072:
URL: https://github.com/apache/echarts/pull/15072
fix(endLabel): endLabel should be displayed if show is true in other states #14441
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
If `endLabel.show` is `false`, endLabel will not show on emphasis even when there is `emphasis.endLabel.show: true`.
### Fixed issues
- #14441: emphasis endlabel does not work
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
End label not show on emphasis
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
End label show on emphasis
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15072: fix(endLabel): endLabel should be displayed if show is true
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15072:
URL: https://github.com/apache/echarts/pull/15072#issuecomment-852904506
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia merged pull request #15072: fix(endLabel): endLabel should be displayed if show is true
Posted by GitBox <gi...@apache.org>.
Ovilia merged pull request #15072:
URL: https://github.com/apache/echarts/pull/15072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #15072: fix(endLabel): endLabel should be displayed if show is true
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #15072:
URL: https://github.com/apache/echarts/pull/15072#discussion_r644487648
##########
File path: src/chart/line/LineView.ts
##########
@@ -412,6 +412,20 @@ function getIndexRange(points: ArrayLike<number>, xOrY: number, dim: 'x' | 'y')
};
}
+function anyStateShowEndLabel(
+ endLabelModel: Model<LineEndLabelOption>, seriesModel: LineSeriesModel
+) {
+ if (endLabelModel.get('show')) {
+ return true;
+ }
+ for (let i = 0; i < DISPLAY_STATES.length; i++) {
Review comment:
Should be SPECIAL_STATES
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #15072: fix(endLabel): endLabel should be displayed if show is true
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #15072:
URL: https://github.com/apache/echarts/pull/15072#discussion_r644487648
##########
File path: src/chart/line/LineView.ts
##########
@@ -412,6 +412,20 @@ function getIndexRange(points: ArrayLike<number>, xOrY: number, dim: 'x' | 'y')
};
}
+function anyStateShowEndLabel(
+ endLabelModel: Model<LineEndLabelOption>, seriesModel: LineSeriesModel
+) {
+ if (endLabelModel.get('show')) {
+ return true;
+ }
+ for (let i = 0; i < DISPLAY_STATES.length; i++) {
Review comment:
Should be SPECIAL_STATES
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15072: fix(endLabel): endLabel should be displayed if show is true
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15072:
URL: https://github.com/apache/echarts/pull/15072#issuecomment-853761180
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia merged pull request #15072: fix(endLabel): endLabel should be displayed if show is true
Posted by GitBox <gi...@apache.org>.
Ovilia merged pull request #15072:
URL: https://github.com/apache/echarts/pull/15072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15072: fix(endLabel): endLabel should be displayed if show is true
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15072:
URL: https://github.com/apache/echarts/pull/15072#issuecomment-853761180
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org