You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Neilblaze (via GitHub)" <gi...@apache.org> on 2023/03/11 12:03:35 UTC
[GitHub] [apisix] Neilblaze opened a new pull request, #9053: replaced profane words with appropriate ones
Neilblaze opened a new pull request, #9053:
URL: https://github.com/apache/apisix/pull/9053
### Description
_**Blacklist**_ and _**whitelist**_ are profane terms. Hence, the usage of appropriate terms like allowlist and denylist is suggested instead in [ua-restriction.md](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/ua-restriction.md#description).
Fixes #9042
cc: @shreemaan-abhishek, @navendu-pottekkat, @nfrankel
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kayx23 merged pull request #9053: docs: replace non-inclusive terms in ua-restriction plugin doc
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 merged PR #9053:
URL: https://github.com/apache/apisix/pull/9053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Neilblaze commented on pull request #9053: docs: replaced profane words with appropriate ones
Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.
Neilblaze commented on PR #9053:
URL: https://github.com/apache/apisix/pull/9053#issuecomment-1482625586
@moonming can we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] navendu-pottekkat commented on a diff in pull request #9053: docs: replaced profane words with appropriate ones
Posted by "navendu-pottekkat (via GitHub)" <gi...@apache.org>.
navendu-pottekkat commented on code in PR #9053:
URL: https://github.com/apache/apisix/pull/9053#discussion_r1136783253
##########
docs/en/latest/plugins/ua-restriction.md:
##########
@@ -30,7 +30,7 @@ description: This document contains information about the Apache APISIX ua-restr
The `ua-restriction` Plugin allows you to restrict access to a Route or Service based on the `User-Agent` header with an `allowlist` and a `denylist`.
-A common scenario is to set crawler rules. `User-Agent` is the identity of the client when sending requests to the server, and the user can whitelist or blacklist some crawler request headers in the `ua-restriction` Plugin.
+A common scenario is to set crawler rules. `User-Agent` is the identity of the client when sending requests to the server, and the user can `allowlist` or `denylist` some crawler request headers in the `ua-restriction` Plugin.
Review Comment:
allowlist and denylist are APISIX terms. They are used to allow or deny request headers. So, this would be better.
##########
docs/en/latest/plugins/ua-restriction.md:
##########
@@ -30,7 +30,7 @@ description: This document contains information about the Apache APISIX ua-restr
The `ua-restriction` Plugin allows you to restrict access to a Route or Service based on the `User-Agent` header with an `allowlist` and a `denylist`.
-A common scenario is to set crawler rules. `User-Agent` is the identity of the client when sending requests to the server, and the user can whitelist or blacklist some crawler request headers in the `ua-restriction` Plugin.
+A common scenario is to set crawler rules. `User-Agent` is the identity of the client when sending requests to the server, and the user can `allowlist` or `denylist` some crawler request headers in the `ua-restriction` Plugin.
Review Comment:
```suggestion
A common scenario is to set crawler rules. `User-Agent` is the identity of the client when sending requests to the server, and the user can allow or deny some crawler request headers in the `ua-restriction` Plugin.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org