[GitHub] [incubator-druid] jihoonson opened a new pull request #9013: Using annotation to distinguish Hadoop Configuration in each module

[GitBox <gi...@apache.org>]

jihoonson opened a new pull request #9013: Using annotation to distinguish Hadoop Configuration in each module
URL: https://github.com/apache/incubator-druid/pull/9013
 
 
   Fixes https://github.com/apache/incubator-druid/issues/9004.
   
   ### Description
   
   This PR is based on https://github.com/apache/incubator-druid/pull/9005.
   
   Each extension module needs to properly bind whatever it will use, but sometimes different modules need to bind the same class which will lead to the duplicate injection error. To avoid this problem, each module is supposed to bind different instances. This PR adds new annotations to bind different instances.
   
   Also `ParquetReader` is changed to use the injected Configuration.
   
   This PR is tested with
   
   - Native orc ingestion
   - Native paquet ingestion
   - Hadoop text file ingestion
   - Hadoop orc ingestion
   - Hadoop parquet ingestion
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `MyFoo`
    * `OurBar`
    * `TheirBaz`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org