You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/14 13:08:44 UTC
[GitHub] [arrow-rs] martin-g opened a new pull request, #1877: Issue #1876 - Explicitly declare the used features for each dependency
martin-g opened a new pull request, #1877:
URL: https://github.com/apache/arrow-rs/pull/1877
# Which issue does this PR close?
This is the first PR for #1876.
It changes just `arrow/Cargo.toml`. If approved then I will do the same for the other modules too!
The PR does **not** upgrade the dependencies!
The changes are tested locally with `cargo +nightly test --all-features`. I've fixed a missing parameter in a method/constructor call.
# Rationale for this change
Reduce the disk and CPU usage at build time.
# What changes are included in this PR?
N/A
# Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #1877: Issue #1876 - Explicitly declare the used features for each dependency
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #1877:
URL: https://github.com/apache/arrow-rs/pull/1877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] martin-g closed pull request #1877: Issue #1876 - Explicitly declare the used features for each dependency
Posted by GitBox <gi...@apache.org>.
martin-g closed pull request #1877: Issue #1876 - Explicitly declare the used features for each dependency
URL: https://github.com/apache/arrow-rs/pull/1877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1877: Issue #1876 - Explicitly declare the used features for each dependency
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1877:
URL: https://github.com/apache/arrow-rs/pull/1877#issuecomment-1155644635
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1877?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1877](https://codecov.io/gh/apache/arrow-rs/pull/1877?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b6cd28) into [master](https://codecov.io/gh/apache/arrow-rs/commit/cedaf8a6ab55826c34f3b1bc9a21dbaf3e0328bc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cedaf8a) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1877 +/- ##
==========================================
- Coverage 83.46% 83.46% -0.01%
==========================================
Files 201 201
Lines 57014 57018 +4
==========================================
+ Hits 47586 47589 +3
- Misses 9428 9429 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1877?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/csv/writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/1877/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2Nzdi93cml0ZXIucnM=) | `71.69% <ø> (ø)` | |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/1877/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.46% <0.00%> (-0.20%)` | :arrow_down: |
| [arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/1877/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2ZmaS5ycw==) | `86.97% <0.00%> (ø)` | |
| [arrow/src/array/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/1877/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2ZmaS5ycw==) | `100.00% <0.00%> (ø)` | |
| [arrow/src/ffi\_stream.rs](https://codecov.io/gh/apache/arrow-rs/pull/1877/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2ZmaV9zdHJlYW0ucnM=) | `79.89% <0.00%> (+0.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1877?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1877?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cedaf8a...0b6cd28](https://codecov.io/gh/apache/arrow-rs/pull/1877?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] martin-g commented on pull request #1877: Issue #1876 - Explicitly declare the used features for each dependency
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1877:
URL: https://github.com/apache/arrow-rs/pull/1877#issuecomment-1156127842
Thanks, @tustvold !
I will start working on the other modules too.
I will open a separate PR for each module!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org