[GitHub] [beam] scwhittle commented on a diff in pull request #21966: add new pubsub urn

[GitBox <gi...@apache.org>]

scwhittle commented on code in PR #21966:
URL: https://github.com/apache/beam/pull/21966#discussion_r918539200


##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -365,6 +365,9 @@ message StandardPTransforms {
     // Represents the GroupIntoBatches.WithShardedKey operation.
     // Payload: GroupIntoBatchesPayload
     GROUP_INTO_BATCHES_WITH_SHARDED_KEY = 6 [(beam_urn) = "beam:transform:group_into_batches_with_sharded_key:v1"];
+
+    // Used for pubsub dynamic destinations.
+    PUBSUB_WRITE_V2 = 7 [(beam_urn) = "beam:transform:pubsub_write:v2"];

Review Comment:
   Thanks, but I realized I was more interested in what the input to the composite transform is.
   See comment for MERGE_WINDOWS
   That I believe would show the difference between v1/v2 because IIRC the v2 that accepts dynamic destinations, each input is a KV or something that contains the destination topic, where v1 may just be accepting pubsub messages. And if my understanding is incorrect, a comment on the expected input would fix that :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org