You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/07 08:07:55 UTC

[GitHub] [shardingsphere] ThanoshanMV opened a new pull request #11692: Add Oracle SQL - Update statement

ThanoshanMV opened a new pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692


   #10111
   
   Hi @wgy8283335, I've added SQL definition for Oracle [UPDATE](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/UPDATE.html#GUID-027A462D-379D-4E35-8611-410F3AC8FDA5) statement. Please check it.
   
   Changes proposed in this pull request:
   - Add Oracle `DELETE` statement.
   - Add test cases.
   - I commented SQL case id `update_with_special_comments` as it's not aligned with Oracle SQL's `returningCluase`:
   
   ![ParsingFailsForReturningClause](https://user-images.githubusercontent.com/48581379/128593319-c2555c0f-c906-4efb-8f94-5e965d36eeee.png)
   
   - As Oracle allows us to set a value to a list of columns, I tried to get the list of column values in the `AssignmentSegment`: 
   
   ![UpdateSetClause](https://user-images.githubusercontent.com/48581379/128593421-24e7a491-1bf0-42e2-a486-e426645617c3.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#issuecomment-894626890


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11692](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7fba441) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0ccdc933736c0355edab5899eedec57ef4c93bab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0ccdc93) will **increase** coverage by `0.03%`.
   > The diff coverage is `50.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11692/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11692      +/-   ##
   ============================================
   + Coverage     63.11%   63.15%   +0.03%     
     Complexity     1225     1225              
   ============================================
     Files          2328     2329       +1     
     Lines         35177    35263      +86     
     Branches       6130     6141      +11     
   ============================================
   + Hits          22203    22271      +68     
   - Misses        11181    11196      +15     
   - Partials       1793     1796       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...meter/impl/EncryptAssignmentParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS9wYXJhbWV0ZXIvaW1wbC9FbmNyeXB0QXNzaWdubWVudFBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...enerator/impl/EncryptAssignmentTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0QXNzaWdubWVudFRva2VuR2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ator/impl/EncryptInsertOnUpdateTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0SW5zZXJ0T25VcGRhdGVUb2tlbkdlbmVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ql/parser/sql/common/extractor/TableExtractor.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL2V4dHJhY3Rvci9UYWJsZUV4dHJhY3Rvci5qYXZh) | `5.40% <0.00%> (ø)` | |
   | [...mmon/segment/dml/assignment/AssignmentSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZG1sL2Fzc2lnbm1lbnQvQXNzaWdubWVudFNlZ21lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...d/asserts/segment/assignment/AssignmentAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L2Fzc2lnbm1lbnQvQXNzaWdubWVudEFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...erts/segment/assignment/AssignmentValueAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L2Fzc2lnbm1lbnQvQXNzaWdubWVudFZhbHVlQXNzZXJ0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/segment/impl/assignment/ExpectedAssignment.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc2VnbWVudC9pbXBsL2Fzc2lnbm1lbnQvRXhwZWN0ZWRBc3NpZ25tZW50LmphdmE=) | `100.00% <ø> (ø)` | |
   | [...gment/impl/assignment/ExpectedAssignmentValue.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc2VnbWVudC9pbXBsL2Fzc2lnbm1lbnQvRXhwZWN0ZWRBc3NpZ25tZW50VmFsdWUuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...meter/impl/ShadowUpdateValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcmV3cml0ZS9wYXJhbWV0ZXIvaW1wbC9TaGFkb3dVcGRhdGVWYWx1ZVBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `33.33% <50.00%> (ø)` | |
   | ... and [15 more](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0ccdc93...7fba441](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r687283411



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
##########
@@ -36,5 +39,7 @@
     
     private final ColumnSegment column;
     
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       Below is not reasonable:
   ```
   @RequiredArgsConstructor
   @Getter
   public final class AssignmentSegment implements SQLSegment {
       
       private final int startIndex;
       
       private final int stopIndex;
       
       private final ColumnSegment column;
   
       private List<ColumnSegment> columns = new LinkedList<>();
       
       private final ExpressionSegment value;
   }
   ```
   But what shall we do in this situation? @jingshanglu @tristaZero 
   ```
   UPDATE employees a SET department_id = (SELECT department_id FROM departments WHERE location_id = '2100'), (salary, commission_pct) = (SELECT 1.1*AVG(salary), 1.5*AVG(commission_pct) FROM employees b WHERE a.department_id = b.department_id);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r684996077



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
##########
@@ -36,5 +39,7 @@
     
     private final ColumnSegment column;
     
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       > And change the value to list
   
   I think we don't have to create a list for value, as an assignment can have only one value:
   
   ![UpdateSetClauseHasOnlyOneAssignmentValue](https://user-images.githubusercontent.com/48581379/128676925-cda31c6d-76b6-445f-beeb-1b23d3a8eb6c.png)
   
   Please let me know what do you think.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#issuecomment-894626890


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11692](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b18da81) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6b462aecd9e0777550fbfa730d6f2c2e6ba17ea4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b462ae) will **decrease** coverage by `0.03%`.
   > The diff coverage is `46.72%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11692/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11692      +/-   ##
   ============================================
   - Coverage     63.43%   63.40%   -0.04%     
     Complexity     1203     1203              
   ============================================
     Files          2319     2320       +1     
     Lines         34996    35073      +77     
     Branches       6077     6088      +11     
   ============================================
   + Hits          22200    22237      +37     
   - Misses        11003    11041      +38     
   - Partials       1793     1795       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...meter/impl/EncryptAssignmentParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS9wYXJhbWV0ZXIvaW1wbC9FbmNyeXB0QXNzaWdubWVudFBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...enerator/impl/EncryptAssignmentTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0QXNzaWdubWVudFRva2VuR2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ator/impl/EncryptInsertOnUpdateTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0SW5zZXJ0T25VcGRhdGVUb2tlbkdlbmVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ql/parser/sql/common/extractor/TableExtractor.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL2V4dHJhY3Rvci9UYWJsZUV4dHJhY3Rvci5qYXZh) | `5.40% <0.00%> (ø)` | |
   | [...mmon/segment/dml/assignment/AssignmentSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZG1sL2Fzc2lnbm1lbnQvQXNzaWdubWVudFNlZ21lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...d/asserts/segment/assignment/AssignmentAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L2Fzc2lnbm1lbnQvQXNzaWdubWVudEFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...erts/segment/assignment/AssignmentValueAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L2Fzc2lnbm1lbnQvQXNzaWdubWVudFZhbHVlQXNzZXJ0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/segment/impl/assignment/ExpectedAssignment.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc2VnbWVudC9pbXBsL2Fzc2lnbm1lbnQvRXhwZWN0ZWRBc3NpZ25tZW50LmphdmE=) | `100.00% <ø> (ø)` | |
   | [...gment/impl/assignment/ExpectedAssignmentValue.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc2VnbWVudC9pbXBsL2Fzc2lnbm1lbnQvRXhwZWN0ZWRBc3NpZ25tZW50VmFsdWUuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...meter/impl/ShadowUpdateValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcmV3cml0ZS9wYXJhbWV0ZXIvaW1wbC9TaGFkb3dVcGRhdGVWYWx1ZVBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `33.33% <50.00%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6b462ae...b18da81](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r690542892



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/ColumnAssignmentSegment.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.common.segment.dml.assignment;
+
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.column.ColumnSegment;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr.ExpressionSegment;
+
+import java.util.LinkedList;
+import java.util.List;
+
+/**
+ * Column Assignment segment.
+ */
+@RequiredArgsConstructor
+@Getter
+public final class ColumnAssignmentSegment extends AssignmentSegment {
+    
+    private final int startIndex;
+    
+    private final int stopIndex;
+    
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       I'll change as `private final List<ColumnSegment> columns`, remove the initialization and make other changes accordingly. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r690542892



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/ColumnAssignmentSegment.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.common.segment.dml.assignment;
+
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.column.ColumnSegment;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr.ExpressionSegment;
+
+import java.util.LinkedList;
+import java.util.List;
+
+/**
+ * Column Assignment segment.
+ */
+@RequiredArgsConstructor
+@Getter
+public final class ColumnAssignmentSegment extends AssignmentSegment {
+    
+    private final int startIndex;
+    
+    private final int stopIndex;
+    
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       I'll change as `private final List<ColumnSegment> columns`, remove the initialization and make other changes accordingly. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#issuecomment-901515880


   @ThanoshanMV, have you finished your modification?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r684991580



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
##########
@@ -36,5 +39,7 @@
     
     private final ColumnSegment column;
     
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       > What about combining the column and columns?
   
   We can combine columns as a list but since the `AssignmentSegment` is used across the ShardingSphere project, we need to make changes in all `AssignmentSegment` occurrences. For example in `EncryptAssignmentParameterRewriter`:
   
   ![AssignmentSegmentUseCases](https://user-images.githubusercontent.com/48581379/128676131-da81db17-f4c7-4e85-8b79-5a1b757a0af7.png)
   
   What shall we do?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#issuecomment-901652395


   > @ThanoshanMV, have you finished your modification?
   
   Yes @wgy8283335. I changed as `private final List<ColumnSegment> columns` and removed commented SQL case id `update_with_special_comments` as it's not aligned with Oracle SQL's returningCluase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r688922505



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
##########
@@ -36,5 +39,7 @@
     
     private final ColumnSegment column;
     
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       Shall we create similar child classes for other SQL dialects, for example, `PostgreSQLAssignmentSegment` or shall we rename `OracleAssignmentSegment` to a generic one?
   
   Currently, whenever we need to create an instance of `AssignmentSegment`, we have to utilize `OracleAssignmentSegment`. In the below image, the method `visitSetClause` is in `PostgreSQLStatementSQLVisitor` which returns an instance of `AssignmentSegment`:
   
   ![PostgreSQLIssue](https://user-images.githubusercontent.com/48581379/129445665-4b112d6b-56c8-4c85-afbf-98ad1ca02456.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r684858982



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
##########
@@ -36,5 +39,7 @@
     
     private final ColumnSegment column;
     
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       What about combine column and columns.
   
   
   ```
   @RequiredArgsConstructor
   @Getter
   public final class AssignmentSegment implements SQLSegment {
       
       private final int startIndex;
       
       private final int stopIndex;
       
       private final List<ColumnSegment> columns;
       
       private final List<ExpressionSegment> values;
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#issuecomment-894626890


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11692](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7fba441) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0ccdc933736c0355edab5899eedec57ef4c93bab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0ccdc93) will **increase** coverage by `0.03%`.
   > The diff coverage is `50.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11692/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11692      +/-   ##
   ============================================
   + Coverage     63.11%   63.15%   +0.03%     
     Complexity     1225     1225              
   ============================================
     Files          2328     2329       +1     
     Lines         35177    35263      +86     
     Branches       6130     6141      +11     
   ============================================
   + Hits          22203    22271      +68     
   - Misses        11181    11196      +15     
   - Partials       1793     1796       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...meter/impl/EncryptAssignmentParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS9wYXJhbWV0ZXIvaW1wbC9FbmNyeXB0QXNzaWdubWVudFBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...enerator/impl/EncryptAssignmentTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0QXNzaWdubWVudFRva2VuR2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ator/impl/EncryptInsertOnUpdateTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0SW5zZXJ0T25VcGRhdGVUb2tlbkdlbmVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ql/parser/sql/common/extractor/TableExtractor.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL2V4dHJhY3Rvci9UYWJsZUV4dHJhY3Rvci5qYXZh) | `5.40% <0.00%> (ø)` | |
   | [...mmon/segment/dml/assignment/AssignmentSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZG1sL2Fzc2lnbm1lbnQvQXNzaWdubWVudFNlZ21lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...d/asserts/segment/assignment/AssignmentAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L2Fzc2lnbm1lbnQvQXNzaWdubWVudEFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...erts/segment/assignment/AssignmentValueAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L2Fzc2lnbm1lbnQvQXNzaWdubWVudFZhbHVlQXNzZXJ0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/segment/impl/assignment/ExpectedAssignment.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc2VnbWVudC9pbXBsL2Fzc2lnbm1lbnQvRXhwZWN0ZWRBc3NpZ25tZW50LmphdmE=) | `100.00% <ø> (ø)` | |
   | [...gment/impl/assignment/ExpectedAssignmentValue.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc2VnbWVudC9pbXBsL2Fzc2lnbm1lbnQvRXhwZWN0ZWRBc3NpZ25tZW50VmFsdWUuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...meter/impl/ShadowUpdateValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcmV3cml0ZS9wYXJhbWV0ZXIvaW1wbC9TaGFkb3dVcGRhdGVWYWx1ZVBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `33.33% <50.00%> (ø)` | |
   | ... and [15 more](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0ccdc93...7fba441](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r688401072



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
##########
@@ -36,5 +39,7 @@
     
     private final ColumnSegment column;
     
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       @wgy8283335 @ThanoshanMV Maybe we can extract abstract class and combine these two idea.
   ```
   public abstract class AssignmentSegment implements SQLSegment {
       
      List<ColumnSegment> getColumns();
      ExpressionSegment getValue();
   }
   
   @RequiredArgsConstructor
   @Getter
   public final class OracleAssignmentSegment extends AssignmentSegment {
       
      private final int startIndex;
       
       private final int stopIndex;
   
       private List<ColumnSegment> columns = new LinkedList<>();
       
       private final ExpressionSegment value;
   }
   ```
   ```
   SET department_id = (SELECT department_id FROM departments WHERE location_id = '2100')
   expressed as
   OracleAssignmentSegment{columns=[department_id],value=subquery}
   
   (salary, commission_pct) = (SELECT 1.1*AVG(salary), 1.5*AVG(commission_pct) FROM employees b WHERE a.department_id = b.department_id)
   expressed as 
   OracleAssignmentSegment{columns=[salary, commission_pct],value=subquery}
   ```
   Maybe it has better decoupling and scalability, but we need to make changes in all `AssignmentSegment` occurrences.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r688906928



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
##########
@@ -36,5 +39,7 @@
     
     private final ColumnSegment column;
     
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       @jingshanglu do you mean like this:
   
   `AssignmentSegment`:
   
   ![AssignmentSegment](https://user-images.githubusercontent.com/48581379/129441421-217ab2bf-5f97-4899-9edf-adf425047d9e.png)
   
   `OracleAssignmentSegment`:
   
   ![OracleAssignmentSegment](https://user-images.githubusercontent.com/48581379/129441447-bf2e0401-289d-4e4e-bc9d-b493941b3f09.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r684858982



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
##########
@@ -36,5 +39,7 @@
     
     private final ColumnSegment column;
     
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       What about combining the column and columns?
   And change the value to list.
   
   ```
   @RequiredArgsConstructor
   @Getter
   public final class AssignmentSegment implements SQLSegment {
       
       private final int startIndex;
       
       private final int stopIndex;
       
       private final List<ColumnSegment> columns;
       
       private final List<ExpressionSegment> values;
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#issuecomment-900808573


   Hi @wgy8283335 Thanks for your tips, all the CI tests passed, do you think this one is ready to merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#issuecomment-900808573


   Hi @wgy8283335 Thanks for your tips, all the CI tests passed, do you think this one is ready to merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#issuecomment-894660457


   Hi @ThanoshanMV ,
   
   Looks our final evaluation is on the way. Let us make it all the way through and win! ;-) @ThanoshanMV @wgy8283335 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r689019699



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
##########
@@ -36,5 +39,7 @@
     
     private final ColumnSegment column;
     
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       > Shall we create similar child classes for other SQL dialects, for example, `PostgreSQLAssignmentSegment` or shall we rename `OracleAssignmentSegment` to a generic one?
   > 
   > Currently, whenever we need to create an instance of `AssignmentSegment`, we have to utilize `OracleAssignmentSegment`. In the below image, the method `visitSetClause` is in `PostgreSQLStatementSQLVisitor` which returns an instance of `AssignmentSegment`:
   > 
   > ![PostgreSQLIssue](https://user-images.githubusercontent.com/48581379/129445665-4b112d6b-56c8-4c85-afbf-98ad1ca02456.png)
   
   @ThanoshanMV Yes, maybe it is better to rename `OracleAssignmentSegment` to a genneric one,  define new subclasses when we need to expand.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#issuecomment-899904479


   There are many changes in this pr, and it's better to make all of the ci checks pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r689943836



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/ColumnAssignmentSegment.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.common.segment.dml.assignment;
+
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.column.ColumnSegment;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr.ExpressionSegment;
+
+import java.util.LinkedList;
+import java.util.List;
+
+/**
+ * Column Assignment segment.
+ */
+@RequiredArgsConstructor
+@Getter
+public final class ColumnAssignmentSegment extends AssignmentSegment {
+    
+    private final int startIndex;
+    
+    private final int stopIndex;
+    
+    private List<ColumnSegment> columns = new LinkedList<>();

Review comment:
       Is it need to be initialized with LinkedList, as ColumnAssignmentSegment has `@RequiredArgsConstructor`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #11692: Add Oracle SQL - Update statement

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#issuecomment-894626890


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11692](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fcdf1a5) into [master](https://codecov.io/gh/apache/shardingsphere/commit/47bf9f433f5055b461332da8eebee6f95d717049?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (47bf9f4) will **increase** coverage by `0.38%`.
   > The diff coverage is `46.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11692/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11692      +/-   ##
   ============================================
   + Coverage     63.25%   63.63%   +0.38%     
   - Complexity     1108     1120      +12     
   ============================================
     Files          2223     2264      +41     
     Lines         34019    34662     +643     
     Branches       5932     6039     +107     
   ============================================
   + Hits          21518    22057     +539     
   - Misses        10769    10839      +70     
   - Partials       1732     1766      +34     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...d/asserts/segment/assignment/AssignmentAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L2Fzc2lnbm1lbnQvQXNzaWdubWVudEFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...erts/segment/assignment/AssignmentValueAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L2Fzc2lnbm1lbnQvQXNzaWdubWVudFZhbHVlQXNzZXJ0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/segment/impl/assignment/ExpectedAssignment.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc2VnbWVudC9pbXBsL2Fzc2lnbm1lbnQvRXhwZWN0ZWRBc3NpZ25tZW50LmphdmE=) | `100.00% <ø> (ø)` | |
   | [...gment/impl/assignment/ExpectedAssignmentValue.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc2VnbWVudC9pbXBsL2Fzc2lnbm1lbnQvRXhwZWN0ZWRBc3NpZ25tZW50VmFsdWUuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...r/statement/impl/OracleDMLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlRE1MU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `74.21% <56.89%> (-2.46%)` | :arrow_down: |
   | [...ql/parser/core/resource/ResourceDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL3Jlc291cmNlL1Jlc291cmNlRGlzdFNRTFBhcnNlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...core/resource/ResourceDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL3Jlc291cmNlL1Jlc291cmNlRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (-91.31%)` | :arrow_down: |
   | [...ore/resource/ResourceSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL3Jlc291cmNlL1Jlc291cmNlU1FMU3RhdGVtZW50UGFyc2VyRW5naW5lLmphdmE=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...itializer/impl/GovernanceBootstrapInitializer.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9pbml0aWFsaXplci9pbXBsL0dvdmVybmFuY2VCb290c3RyYXBJbml0aWFsaXplci5qYXZh) | `20.00% <0.00%> (-58.73%)` | :arrow_down: |
   | [...ce/core/yaml/pojo/YamlGovernanceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS95YW1sL3Bvam8vWWFtbEdvdmVybmFuY2VDb25maWd1cmF0aW9uLmphdmE=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | ... and [238 more](https://codecov.io/gh/apache/shardingsphere/pull/11692/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [47bf9f4...fcdf1a5](https://codecov.io/gh/apache/shardingsphere/pull/11692?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org