[GitHub] eolivelli commented on a change in pull request #1530: Add a deployment method using docker-compose

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1530: Add a deployment method using docker-compose
URL: https://github.com/apache/bookkeeper/pull/1530#discussion_r198367926
 
 

 ##########
 File path: deploy/docker-compose/compose/values.yaml
 ##########
 @@ -0,0 +1,47 @@
+#/**
+# * Licensed to the Apache Software Foundation (ASF) under one
+# * or more contributor license agreements.  See the NOTICE file
+# * distributed with this work for additional information
+# * regarding copyright ownership.  The ASF licenses this file
+# * to you under the Apache License, Version 2.0 (the
+# * "License"); you may not use this file except in compliance
+# * with the License.  You may obtain a copy of the License at
+# *
+# *     http://www.apache.org/licenses/LICENSE-2.0
+# *
+# * Unless required by applicable law or agreed to in writing, software
+# * distributed under the License is distributed on an "AS IS" BASIS,
+# * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# * See the License for the specific language governing permissions and
+# * limitations under the License.
+# */
+
+# data directories
+dataDir: ./data
+
+# advertised address that bookies used for advertising themselves.
+# host network mode is useless on Mac, so in order to let clients
+# on the host accessing bookies in the docker network, we can set
+# the advertisedAddr to let bookies advertised in a host network.
+#
+# comment it out if you are not running on Mac
+advertisedAddr: 127.0.0.1
 
 Review comment:
   On linux? Does this work anyway?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services