You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2020/03/10 09:36:01 UTC
[GitHub] [unomi] sergehuber opened a new pull request #134: UNOMI-284 Make
mapping total fields limit configurable
sergehuber opened a new pull request #134: UNOMI-284 Make mapping total fields limit configurable
URL: https://github.com/apache/unomi/pull/134
For some usages the default limit (1000) is too low. This modification makes it configurable, especially for dynamically created indices.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] Taybou commented on a change in pull request #134:
UNOMI-284 Make mapping total fields limit configurable
Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #134: UNOMI-284 Make mapping total fields limit configurable
URL: https://github.com/apache/unomi/pull/134#discussion_r390349893
##########
File path: persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
##########
@@ -1056,7 +1056,8 @@ private void internalCreateIndex(String indexName, String mappingSource) throws
createIndexRequest.settings("{\n" +
" \"index\" : {\n" +
" \"number_of_shards\" : " + numberOfShards + ",\n" +
- " \"number_of_replicas\" : " + numberOfReplicas + "\n" +
+ " \"number_of_replicas\" : " + numberOfReplicas + ",\n" +
+ " \"index.mapping.total_fields.limit\" : " + monthlyIndexMappingTotalFieldsLimit + "\n" +
Review comment:
```suggestion
" \"index.mapping.total_fields.limit\" : " + indexMappingTotalFieldsLimit + "\n" +
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] sergehuber merged pull request #134: UNOMI-284 Make mapping
total fields limit configurable
Posted by GitBox <gi...@apache.org>.
sergehuber merged pull request #134: UNOMI-284 Make mapping total fields limit configurable
URL: https://github.com/apache/unomi/pull/134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] sergehuber commented on a change in pull request #134:
UNOMI-284 Make mapping total fields limit configurable
Posted by GitBox <gi...@apache.org>.
sergehuber commented on a change in pull request #134: UNOMI-284 Make mapping total fields limit configurable
URL: https://github.com/apache/unomi/pull/134#discussion_r390818442
##########
File path: persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
##########
@@ -139,8 +139,10 @@
private String indexPrefix;
private String monthlyIndexNumberOfShards;
private String monthlyIndexNumberOfReplicas;
+ private String monthlyIndexMappingTotalFieldsLimit;
private String numberOfShards;
private String numberOfReplicas;
+ private String indexMappingTotalFieldsLimit;
Review comment:
It was a mistake. I added it (with a bad copy-paste) but I committed your fix. Thanks for catching this (twice !)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [unomi] Taybou commented on a change in pull request #134:
UNOMI-284 Make mapping total fields limit configurable
Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #134: UNOMI-284 Make mapping total fields limit configurable
URL: https://github.com/apache/unomi/pull/134#discussion_r390340397
##########
File path: persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
##########
@@ -139,8 +139,10 @@
private String indexPrefix;
private String monthlyIndexNumberOfShards;
private String monthlyIndexNumberOfReplicas;
+ private String monthlyIndexMappingTotalFieldsLimit;
private String numberOfShards;
private String numberOfReplicas;
+ private String indexMappingTotalFieldsLimit;
Review comment:
Why you didn't add this property to the internal create index mapping?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services