[GitHub] [hive] vineetgarg02 commented on a change in pull request #1231: HIVE-23822 Sorted dynamic partition optimization could remove auto stat task

[GitBox <gi...@apache.org>]

vineetgarg02 commented on a change in pull request #1231:
URL: https://github.com/apache/hive/pull/1231#discussion_r454462383



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java
##########
@@ -409,26 +409,54 @@ private boolean removeRSInsertedByEnforceBucketing(FileSinkOperator fsOp) {
       // and grand child
       if (found) {
         Operator<? extends OperatorDesc> rsParent = rsToRemove.getParentOperators().get(0);
-        Operator<? extends OperatorDesc> rsChild = rsToRemove.getChildOperators().get(0);
-        Operator<? extends OperatorDesc> rsGrandChild = rsChild.getChildOperators().get(0);
-
-        if (rsChild instanceof SelectOperator) {
-          // if schema size cannot be matched, then it could be because of constant folding
-          // converting partition column expression to constant expression. The constant
-          // expression will then get pruned by column pruner since it will not reference to
-          // any columns.
-          if (rsParent.getSchema().getSignature().size() !=
-              rsChild.getSchema().getSignature().size()) {
+        List<Operator<? extends OperatorDesc>> rsChildren = rsToRemove.getChildOperators();
+
+        Operator<? extends OperatorDesc> rsChildToRemove = null;
+
+        for (Operator<? extends OperatorDesc> rsChild : rsChildren) {

Review comment:
       I assumed that this could be possibility and therefore accounted for it, but if this assumption is wrong I update the code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org