You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/06/08 22:39:41 UTC
[Toolchain-CR] IMPALA-3507: binutils fix for slow linking
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3341
Change subject: IMPALA-3507: binutils fix for slow linking
......................................................................
IMPALA-3507: binutils fix for slow linking
Linking with ld from binutils-2.26 could be extremely slow.
because of https://sourceware.org/bugzilla/show_bug.cgi?id=19542
This commit adds the patch linked from the previous bug.
I stripped out the CHANGELOG change from the patch, since that didn't
merge cleanly.
Testing:
Built locally and tested compiling Impala with ASAN (which falls back to
ld from ld.gold on my system). The linking time is now ~15s instead of
minutes, and running some basic queries works fine.
Change-Id: Icabe5301f279b0fdc924963edef88d147f70a9ac
---
M init.sh
A source/binutils/binutils-2.26-patches/0001-Store-estimated-istrances-in-compressed_size.patch
2 files changed, 88 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/41/3341/1
--
To view, visit http://gerrit.cloudera.org:8080/3341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icabe5301f279b0fdc924963edef88d147f70a9ac
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Toolchain-CR] IMPALA-3507: binutils fix for slow linking
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3507: binutils fix for slow linking
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icabe5301f279b0fdc924963edef88d147f70a9ac
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-3507: binutils fix for slow linking
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3507: binutils fix for slow linking
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icabe5301f279b0fdc924963edef88d147f70a9ac
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-3507: binutils fix for slow linking
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3507: binutils fix for slow linking
......................................................................
Patch Set 1:
http://unittest.jenkins.cloudera.com/job/verify-impala-toolchain-package-build/210/
--
To view, visit http://gerrit.cloudera.org:8080/3341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icabe5301f279b0fdc924963edef88d147f70a9ac
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-3507: binutils fix for slow linking
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-3507: binutils fix for slow linking
......................................................................
IMPALA-3507: binutils fix for slow linking
Linking with ld from binutils-2.26 could be extremely slow.
because of https://sourceware.org/bugzilla/show_bug.cgi?id=19542
This commit adds the patch linked from the previous bug.
I stripped out the CHANGELOG change from the patch, since that didn't
merge cleanly.
Testing:
Built locally and tested compiling Impala with ASAN (which falls back to
ld from ld.gold on my system). The linking time is now ~15s instead of
minutes, and running some basic queries works fine.
Change-Id: Icabe5301f279b0fdc924963edef88d147f70a9ac
---
M init.sh
A source/binutils/binutils-2.26-patches/0001-Store-estimated-istrances-in-compressed_size.patch
2 files changed, 88 insertions(+), 1 deletion(-)
Approvals:
Jim Apple: Looks good to me, approved
Tim Armstrong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icabe5301f279b0fdc924963edef88d147f70a9ac
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>