You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2010/07/14 09:01:53 UTC
[jira] Created: (ZOOKEEPER-814) monitoring scripts are missing
apache license headers
monitoring scripts are missing apache license headers
-----------------------------------------------------
Key: ZOOKEEPER-814
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-814
Project: Zookeeper
Issue Type: Bug
Components: contrib
Reporter: Patrick Hunt
Assignee: Andrei Savu
Priority: Blocker
Fix For: 3.4.0
Andrei, I just realized that src/contrib/monitoring files are missing apache license headers. Please add them (in particular any script files like python, see similar files in svn for examples - in some cases like README it's not strictly necessary.)
You can run the RAT tool to verify (see build.xml or http://incubator.apache.org/rat/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-814) monitoring scripts are missing
apache license headers
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888240#action_12888240 ]
Hadoop QA commented on ZOOKEEPER-814:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12449427/ZOOKEEPER-814.patch
against trunk revision 963957.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/143/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/143/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/143/console
This message is automatically generated.
> monitoring scripts are missing apache license headers
> -----------------------------------------------------
>
> Key: ZOOKEEPER-814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-814
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib
> Reporter: Patrick Hunt
> Assignee: Andrei Savu
> Priority: Blocker
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-814.patch
>
>
> Andrei, I just realized that src/contrib/monitoring files are missing apache license headers. Please add them (in particular any script files like python, see similar files in svn for examples - in some cases like README it's not strictly necessary.)
> You can run the RAT tool to verify (see build.xml or http://incubator.apache.org/rat/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-814) monitoring scripts are missing
apache license headers
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated ZOOKEEPER-814:
----------------------------------
Status: Patch Available (was: Open)
> monitoring scripts are missing apache license headers
> -----------------------------------------------------
>
> Key: ZOOKEEPER-814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-814
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib
> Reporter: Patrick Hunt
> Assignee: Andrei Savu
> Priority: Blocker
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-814.patch
>
>
> Andrei, I just realized that src/contrib/monitoring files are missing apache license headers. Please add them (in particular any script files like python, see similar files in svn for examples - in some cases like README it's not strictly necessary.)
> You can run the RAT tool to verify (see build.xml or http://incubator.apache.org/rat/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-814) monitoring scripts are missing
apache license headers
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892493#action_12892493 ]
Mahadev konar commented on ZOOKEEPER-814:
-----------------------------------------
+1 the patch looks good.
Andrei,
I think the monitoring tools and scripts are quite useful, though it would have been great to have forrest docs for all the plugins like ganglia/others, so that we can publish them as part of the release documentation!! Please consider adding forrest documentation (it should not be hard at all)!!! It would be really good to have admin documentation link to these forrest docs in case they want to use it!
Having all the documentation as forrest docs and availalbe on the documentation website (as part of release) will highly increase the adoption of such a plugin!
> monitoring scripts are missing apache license headers
> -----------------------------------------------------
>
> Key: ZOOKEEPER-814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-814
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib
> Reporter: Patrick Hunt
> Assignee: Andrei Savu
> Priority: Blocker
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-814.patch
>
>
> Andrei, I just realized that src/contrib/monitoring files are missing apache license headers. Please add them (in particular any script files like python, see similar files in svn for examples - in some cases like README it's not strictly necessary.)
> You can run the RAT tool to verify (see build.xml or http://incubator.apache.org/rat/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-814) monitoring scripts are missing
apache license headers
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated ZOOKEEPER-814:
----------------------------------
Attachment: ZOOKEEPER-814.patch
Added license headers to all files. Sorry about missing this in the first place.
> monitoring scripts are missing apache license headers
> -----------------------------------------------------
>
> Key: ZOOKEEPER-814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-814
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib
> Reporter: Patrick Hunt
> Assignee: Andrei Savu
> Priority: Blocker
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-814.patch
>
>
> Andrei, I just realized that src/contrib/monitoring files are missing apache license headers. Please add them (in particular any script files like python, see similar files in svn for examples - in some cases like README it's not strictly necessary.)
> You can run the RAT tool to verify (see build.xml or http://incubator.apache.org/rat/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-814) monitoring scripts are missing
apache license headers
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-814:
------------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
I just committed this.
thanks andrei!
> monitoring scripts are missing apache license headers
> -----------------------------------------------------
>
> Key: ZOOKEEPER-814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-814
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib
> Reporter: Patrick Hunt
> Assignee: Andrei Savu
> Priority: Blocker
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-814.patch
>
>
> Andrei, I just realized that src/contrib/monitoring files are missing apache license headers. Please add them (in particular any script files like python, see similar files in svn for examples - in some cases like README it's not strictly necessary.)
> You can run the RAT tool to verify (see build.xml or http://incubator.apache.org/rat/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-814) monitoring scripts are missing
apache license headers
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892747#action_12892747 ]
Hudson commented on ZOOKEEPER-814:
----------------------------------
Integrated in ZooKeeper-trunk #887 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/887/])
ZOOKEEPER-814. monitoring scripts are missing apache license headers (andrei savu via mahadev)
> monitoring scripts are missing apache license headers
> -----------------------------------------------------
>
> Key: ZOOKEEPER-814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-814
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib
> Reporter: Patrick Hunt
> Assignee: Andrei Savu
> Priority: Blocker
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-814.patch
>
>
> Andrei, I just realized that src/contrib/monitoring files are missing apache license headers. Please add them (in particular any script files like python, see similar files in svn for examples - in some cases like README it's not strictly necessary.)
> You can run the RAT tool to verify (see build.xml or http://incubator.apache.org/rat/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-814) monitoring scripts are missing
apache license headers
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892680#action_12892680 ]
Andrei Savu commented on ZOOKEEPER-814:
---------------------------------------
thanks Mahadev!
> monitoring scripts are missing apache license headers
> -----------------------------------------------------
>
> Key: ZOOKEEPER-814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-814
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib
> Reporter: Patrick Hunt
> Assignee: Andrei Savu
> Priority: Blocker
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-814.patch
>
>
> Andrei, I just realized that src/contrib/monitoring files are missing apache license headers. Please add them (in particular any script files like python, see similar files in svn for examples - in some cases like README it's not strictly necessary.)
> You can run the RAT tool to verify (see build.xml or http://incubator.apache.org/rat/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.