You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/19 16:31:47 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #15748: [BEAM-13079] Updates cross-language transform URNs to use the new convention

TheNeuralBit commented on a change in pull request #15748:
URL: https://github.com/apache/beam/pull/15748#discussion_r732048522



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerTransformRegistrar.java
##########
@@ -51,13 +51,13 @@
 @Experimental(Kind.PORTABILITY)
 @AutoService(ExternalTransformRegistrar.class)
 public class SpannerTransformRegistrar implements ExternalTransformRegistrar {
-  public static final String INSERT_URN = "beam:external:java:spanner:insert:v1";
-  public static final String UPDATE_URN = "beam:external:java:spanner:update:v1";
-  public static final String REPLACE_URN = "beam:external:java:spanner:replace:v1";
+  public static final String INSERT_URN = "beam:transform:org.apache.beam:spanner_read:v1";

Review comment:
       ```suggestion
     public static final String INSERT_URN = "beam:transform:org.apache.beam:spanner_insert:v1";
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org