You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/04/20 04:09:27 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #1168: Fix: use triple v0.1.2, split dubbogo from triple
LaurenceLiZhixin opened a new pull request #1168:
URL: https://github.com/apache/dubbo-go/pull/1168
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1168: Fix: use triple v0.1.2, split dubbogo from triple
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1168:
URL: https://github.com/apache/dubbo-go/pull/1168#discussion_r618147501
##########
File path: protocol/dubbo3/dubbo3_protocol.go
##########
@@ -17,16 +17,17 @@
package dubbo3
import (
+ "context"
"fmt"
+ "github.com/apache/dubbo-go/protocol/invocation"
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1168: Fix: use triple v0.1.2, split dubbogo from triple
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1168:
URL: https://github.com/apache/dubbo-go/pull/1168#discussion_r616343483
##########
File path: protocol/dubbo3/dubbo3_protocol.go
##########
@@ -17,16 +17,17 @@
package dubbo3
import (
+ "context"
"fmt"
+ "github.com/apache/dubbo-go/protocol/invocation"
Review comment:
split
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1168: Fix: use triple v0.1.2, split dubbogo from triple
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #1168:
URL: https://github.com/apache/dubbo-go/pull/1168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1168: Fix: use triple v0.1.2, split dubbogo from triple
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1168:
URL: https://github.com/apache/dubbo-go/pull/1168#discussion_r618228161
##########
File path: protocol/dubbo3/dubbo3_protocol.go
##########
@@ -139,7 +140,7 @@ func (dp *DubboProtocol) Destroy() {
}
}
-// Dubbo3GrpcService is gRPC service
+// Dubbo3GrpcService is gRPC service
Review comment:
fixed
##########
File path: registry/consul/service_discovery_test.go
##########
@@ -152,7 +152,9 @@ func TestConsulServiceDiscovery_CRUD(t *testing.T) {
// assert.Nil(t, err)
// test AddListener
- hs := &gxset.HashSet{}
+ hs := &gxset.HashSet{
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on a change in pull request #1168: Fix: use triple v0.1.2, split dubbogo from triple
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on a change in pull request #1168:
URL: https://github.com/apache/dubbo-go/pull/1168#discussion_r618165101
##########
File path: registry/consul/service_discovery_test.go
##########
@@ -152,7 +152,9 @@ func TestConsulServiceDiscovery_CRUD(t *testing.T) {
// assert.Nil(t, err)
// test AddListener
- hs := &gxset.HashSet{}
+ hs := &gxset.HashSet{
Review comment:
Use `gxset.NewHashSet()` directly.
##########
File path: protocol/dubbo3/dubbo3_protocol.go
##########
@@ -139,7 +140,7 @@ func (dp *DubboProtocol) Destroy() {
}
}
-// Dubbo3GrpcService is gRPC service
+// Dubbo3GrpcService is gRPC service
Review comment:
Keep original comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1168: Fix: use triple v0.1.2, split dubbogo from triple
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1168:
URL: https://github.com/apache/dubbo-go/pull/1168#discussion_r618132237
##########
File path: registry/consul/service_discovery.go
##########
@@ -38,6 +38,7 @@ import (
"github.com/apache/dubbo-go/common/extension"
"github.com/apache/dubbo-go/common/logger"
"github.com/apache/dubbo-go/config"
+ _ "github.com/apache/dubbo-go/metadata/mapping/memory"
Review comment:
It's needed when testing consul service discovery. If not, It will panic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on a change in pull request #1168: Fix: use triple v0.1.2, split dubbogo from triple
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on a change in pull request #1168:
URL: https://github.com/apache/dubbo-go/pull/1168#discussion_r617183722
##########
File path: registry/nacos/registry_test.go
##########
@@ -65,6 +65,7 @@ func TestNacosRegistry_Register(t *testing.T) {
t.Errorf("register error:%s \n", err.Error())
return
}
+ time.Sleep(time.Second)
Review comment:
Why add sleep?
##########
File path: registry/consul/service_discovery.go
##########
@@ -38,6 +38,7 @@ import (
"github.com/apache/dubbo-go/common/extension"
"github.com/apache/dubbo-go/common/logger"
"github.com/apache/dubbo-go/config"
+ _ "github.com/apache/dubbo-go/metadata/mapping/memory"
Review comment:
Why import `_ "github.com/apache/dubbo-go/metadata/mapping/memory"`?
##########
File path: registry/zookeeper/service_discovery_test.go
##########
@@ -64,6 +65,8 @@ func TestNewZookeeperServiceDiscovery(t *testing.T) {
name := "zookeeper1"
_, err := newZookeeperServiceDiscovery(name)
+ time.Sleep(time.Second)
Review comment:
Why add sleep?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1168: Fix: use triple v0.1.2, split dubbogo from triple
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1168:
URL: https://github.com/apache/dubbo-go/pull/1168#discussion_r618131768
##########
File path: registry/zookeeper/service_discovery_test.go
##########
@@ -64,6 +65,8 @@ func TestNewZookeeperServiceDiscovery(t *testing.T) {
name := "zookeeper1"
_, err := newZookeeperServiceDiscovery(name)
+ time.Sleep(time.Second)
Review comment:
Thanks for mentioned, It's just for test, Now I delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org