You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2019/09/17 17:05:00 UTC

[jira] [Commented] (ARROW-6299) [C++] Simplify FileFormat classes to singletons

    [ https://issues.apache.org/jira/browse/ARROW-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931660#comment-16931660 ] 

Antoine Pitrou commented on ARROW-6299:
---------------------------------------

You can have factory functions returning global singletons (like we have for non-parametric types) and still keep the classes.

> [C++] Simplify FileFormat classes to singletons
> -----------------------------------------------
>
>                 Key: ARROW-6299
>                 URL: https://issues.apache.org/jira/browse/ARROW-6299
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Benjamin Kietzman
>            Assignee: Benjamin Kietzman
>            Priority: Minor
>              Labels: dataset
>             Fix For: 1.0.0
>
>
> ParquetFileFormat has no state, so passing it around by shared_ptr<FileFormat> is not necessary; we could just keep a single static instance and pass raw pointers.
> [~wesmckinn] is there a case where a FileFormat might have state?



--
This message was sent by Atlassian Jira
(v8.3.2#803003)