You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2014/02/07 13:44:26 UTC

Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/
-----------------------------------------------------------

Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.


Bugs: CLOUDSTACK-6058
    https://issues.apache.org/jira/browse/CLOUDSTACK-6058


Repository: cloudstack-git


Description
-------

Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.

1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.


Diffs
-----

  deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
  deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
  deps/XenServerJava/src/Makefile PRE-CREATION 
  deps/XenServerJava/src/README.txt PRE-CREATION 
  deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
  deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
  deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
  deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
  deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
  deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
  deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
  deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
  deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
  deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
  deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
  deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
  deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
  deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
  deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
  deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
  deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
  deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
  deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
  deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
  deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
  deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
  deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
  deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
  deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
  deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
  deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
  deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
  deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
  deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
  deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
  deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
  deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
  deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
  deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
  deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
  deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
  deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
  deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
  deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
  deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
  deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
  deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
  deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
  deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
  deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
  deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
  deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
  deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
  deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
  deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 

Diff: https://reviews.apache.org/r/17843/diff/


Testing
-------


Thanks,

Sanjay Tripathi


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by Hugo Trippaers <ht...@schubergphilis.com>.

> On Feb. 19, 2014, 9:27 p.m., Hugo Trippaers wrote:
> > It looks like a lot of the license headers are wrong in this file. Please make sure they are complying to the license headers as they should be for CloudStack code. See the LICENSE.header file for examples, especially the copyright notice should not be there.
> > 
> > Also isn't this a good time to feed the changes we need in the java bindings back to the xen-api-sdk project on github (https://github.com/xapi-project/xen-api-sdk)? It would be nice if we could just depend on that project instead of having to include a copy in our own source tree.
> 
> David Nalley wrote:
>     This is not CloudStack code. This is a dependency that we've effectively forked. We have no standing to change the license headers; it's not ours. 
>     
>     Wholeheartedly agree - I'd far prefer we upstream our changes and stop bundling this dependency. 
>     
>     --David
> 
> Sanjay Tripathi wrote:
>     That's right, we cannot change the Licence headers.
>     
>     As of now, with the released java bindings, there is some customization required to make it work with CloudStack (see the patch https://reviews.apache.org/r/17844/).
>     
>     If i am right, in the upcoming XenServer hotfix release, all the customization related to CloudStack code has been taken care of. So, in future, with that release, we can directly use the build instead of building it of our own.
>     
>     Please share your thoughts on this.
>     
>     Also, this patch has the support of vGPU functionality in XenServer which is a dependency for upcoming feature "GPU and vGPU support for CloudStack guestVms".
>     
>     --Sanjay

Sanjay,

I double checked the license headers. This is a BSD two clause license, so perfectly OK to include in our sourcecode. Consider my worries resolved :-)


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review34930
-----------------------------------------------------------


On Feb. 19, 2014, 7:31 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 7:31 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.
> 
> 
> Diffs
> -----
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/Makefile PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 
> 
> Diff: https://reviews.apache.org/r/17843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by David Nalley <da...@gnsa.us>.

> On Feb. 19, 2014, 9:27 p.m., Hugo Trippaers wrote:
> > It looks like a lot of the license headers are wrong in this file. Please make sure they are complying to the license headers as they should be for CloudStack code. See the LICENSE.header file for examples, especially the copyright notice should not be there.
> > 
> > Also isn't this a good time to feed the changes we need in the java bindings back to the xen-api-sdk project on github (https://github.com/xapi-project/xen-api-sdk)? It would be nice if we could just depend on that project instead of having to include a copy in our own source tree.

This is not CloudStack code. This is a dependency that we've effectively forked. We have no standing to change the license headers; it's not ours. 

Wholeheartedly agree - I'd far prefer we upstream our changes and stop bundling this dependency. 

--David


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review34930
-----------------------------------------------------------


On Feb. 19, 2014, 7:31 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 7:31 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.
> 
> 
> Diffs
> -----
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/Makefile PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 
> 
> Diff: https://reviews.apache.org/r/17843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by Sanjay Tripathi <sa...@citrix.com>.

> On Feb. 19, 2014, 9:27 p.m., Hugo Trippaers wrote:
> > It looks like a lot of the license headers are wrong in this file. Please make sure they are complying to the license headers as they should be for CloudStack code. See the LICENSE.header file for examples, especially the copyright notice should not be there.
> > 
> > Also isn't this a good time to feed the changes we need in the java bindings back to the xen-api-sdk project on github (https://github.com/xapi-project/xen-api-sdk)? It would be nice if we could just depend on that project instead of having to include a copy in our own source tree.
> 
> David Nalley wrote:
>     This is not CloudStack code. This is a dependency that we've effectively forked. We have no standing to change the license headers; it's not ours. 
>     
>     Wholeheartedly agree - I'd far prefer we upstream our changes and stop bundling this dependency. 
>     
>     --David

That's right, we cannot change the Licence headers.

As of now, with the released java bindings, there is some customization required to make it work with CloudStack (see the patch https://reviews.apache.org/r/17844/).

If i am right, in the upcoming XenServer hotfix release, all the customization related to CloudStack code has been taken care of. So, in future, with that release, we can directly use the build instead of building it of our own.

Please share your thoughts on this.

Also, this patch has the support of vGPU functionality in XenServer which is a dependency for upcoming feature "GPU and vGPU support for CloudStack guestVms".

--Sanjay


- Sanjay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review34930
-----------------------------------------------------------


On Feb. 19, 2014, 7:31 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 7:31 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.
> 
> 
> Diffs
> -----
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/Makefile PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 
> 
> Diff: https://reviews.apache.org/r/17843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review34930
-----------------------------------------------------------


It looks like a lot of the license headers are wrong in this file. Please make sure they are complying to the license headers as they should be for CloudStack code. See the LICENSE.header file for examples, especially the copyright notice should not be there.

Also isn't this a good time to feed the changes we need in the java bindings back to the xen-api-sdk project on github (https://github.com/xapi-project/xen-api-sdk)? It would be nice if we could just depend on that project instead of having to include a copy in our own source tree.

- Hugo Trippaers


On Feb. 19, 2014, 7:31 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 7:31 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.
> 
> 
> Diffs
> -----
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/Makefile PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 
> 
> Diff: https://reviews.apache.org/r/17843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review35264
-----------------------------------------------------------


Before we commit this, can you have a look at these two remarks?


deps/XenServerJava/src/Makefile
<https://reviews.apache.org/r/17843/#comment65725>

    can you remove the Makefile? We would using maven and we should try not to confuse our developers with other make methods.



deps/XenServerJava/src/README.txt
<https://reviews.apache.org/r/17843/#comment65726>

    I've we want to include this README, we should be a note in it that this is a modified version.


- Hugo Trippaers


On Feb. 19, 2014, 7:31 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 7:31 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.
> 
> 
> Diffs
> -----
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/Makefile PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 
> 
> Diff: https://reviews.apache.org/r/17843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review35388
-----------------------------------------------------------

Ship it!


commit 2ff9abadf6e6af835f2835ea09e1d8b5421800d0
Author: Sanjay Tripathi <sa...@citrix.com>
Date:   Wed Jan 22 16:15:52 2014 +0530

    CLOUDSTACK-6058: New XenServer 6.2sp1 SDKs
    
    This commit replaces old XenServer SDKs with lastet XenServer release
    i.e. 6.2sp1 SDKs. This SDK also includes new class "VGPU" to support
    vGPU functionality in XenServer.
    
    Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>


- Hugo Trippaers


On Feb. 24, 2014, 5:07 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 5:07 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.
> 
> 
> Diffs
> -----
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 
> 
> Diff: https://reviews.apache.org/r/17843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review35374
-----------------------------------------------------------


Commit 4e0c1bb4e1c4711ed40737fc20fafe6126de733b in cloudstack's branch refs/heads/xenserverJAVA from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4e0c1bb ]

CLOUDSTACK-6058: XenServer 6.2sp1 xenapi customization as per CloudStack resource code.


- ASF Subversion and Git Services


On Feb. 24, 2014, 5:07 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 5:07 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.
> 
> 
> Diffs
> -----
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 
> 
> Diff: https://reviews.apache.org/r/17843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review35384
-----------------------------------------------------------


Commit 505da760e065450f52f3a22649bd648af8f9c854 in cloudstack's branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=505da76 ]

CLOUDSTACK-6058: XenServer 6.2sp1 xenapi customization as per CloudStack resource code.

Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>


- ASF Subversion and Git Services


On Feb. 24, 2014, 5:07 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 5:07 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.
> 
> 
> Diffs
> -----
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 
> 
> Diff: https://reviews.apache.org/r/17843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review35373
-----------------------------------------------------------


Commit f501ec694ed94f6417354a24ea44ee09967cf25f in cloudstack's branch refs/heads/xenserverJAVA from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f501ec6 ]

CLOUDSTACK-6058: New XenServer 6.2sp1 SDKs

This commit replaces old XenServer SDKs with lastet XenServer release
i.e. 6.2sp1 SDKs. This SDK also includes new class "VGPU" to support
vGPU functionality in XenServer.


- ASF Subversion and Git Services


On Feb. 24, 2014, 5:07 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 5:07 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.
> 
> 
> Diffs
> -----
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 
> 
> Diff: https://reviews.apache.org/r/17843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review35383
-----------------------------------------------------------


Commit 2ff9abadf6e6af835f2835ea09e1d8b5421800d0 in cloudstack's branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2ff9aba ]

CLOUDSTACK-6058: New XenServer 6.2sp1 SDKs

This commit replaces old XenServer SDKs with lastet XenServer release
i.e. 6.2sp1 SDKs. This SDK also includes new class "VGPU" to support
vGPU functionality in XenServer.

Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>


- ASF Subversion and Git Services


On Feb. 24, 2014, 5:07 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 5:07 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.
> 
> 
> Diffs
> -----
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
>   deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
>   deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
>   deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
>   deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 
> 
> Diff: https://reviews.apache.org/r/17843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/
-----------------------------------------------------------

(Updated Feb. 24, 2014, 5:07 p.m.)


Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.


Changes
-------

Incorporated the changes suggested by Hugo and rebased the patch with latest master.


Bugs: CLOUDSTACK-6058
    https://issues.apache.org/jira/browse/CLOUDSTACK-6058


Repository: cloudstack-git


Description
-------

Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.

1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.


Diffs (updated)
-----

  deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
  deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
  deps/XenServerJava/src/README.txt PRE-CREATION 
  deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
  deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
  deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
  deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
  deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
  deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
  deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
  deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
  deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
  deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
  deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
  deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
  deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
  deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
  deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
  deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
  deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
  deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
  deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
  deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
  deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
  deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
  deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
  deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
  deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
  deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
  deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
  deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
  deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
  deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
  deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
  deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
  deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
  deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
  deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
  deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
  deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
  deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
  deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
  deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
  deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
  deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
  deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
  deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
  deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
  deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
  deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
  deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
  deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
  deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
  deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 

Diff: https://reviews.apache.org/r/17843/diff/


Testing
-------


Thanks,

Sanjay Tripathi


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/
-----------------------------------------------------------

(Updated Feb. 19, 2014, 7:31 p.m.)


Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.


Bugs: CLOUDSTACK-6058
    https://issues.apache.org/jira/browse/CLOUDSTACK-6058


Repository: cloudstack-git


Description
-------

Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.

1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.


Diffs
-----

  deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
  deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
  deps/XenServerJava/src/Makefile PRE-CREATION 
  deps/XenServerJava/src/README.txt PRE-CREATION 
  deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
  deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
  deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
  deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
  deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
  deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
  deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
  deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
  deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
  deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
  deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
  deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
  deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
  deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
  deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
  deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
  deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
  deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
  deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
  deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
  deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
  deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
  deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
  deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
  deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
  deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
  deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
  deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
  deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
  deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
  deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
  deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
  deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
  deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
  deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
  deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
  deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
  deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
  deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
  deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
  deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
  deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
  deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
  deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
  deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
  deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
  deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
  deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
  deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
  deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
  deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 

Diff: https://reviews.apache.org/r/17843/diff/


Testing
-------


Thanks,

Sanjay Tripathi


Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/
-----------------------------------------------------------

(Updated Feb. 19, 2014, 7:30 p.m.)


Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.


Changes
-------

Rebased with latest master.


Bugs: CLOUDSTACK-6058
    https://issues.apache.org/jira/browse/CLOUDSTACK-6058


Repository: cloudstack-git


Description
-------

Update the java bindings that are used in cloudstack with the latest one. There are two parts for this change, 1st one is to replace the java bindings; and second part is to add the customization's made in xenapi for Cloudstack.

1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for CloudStack.


Diffs (updated)
-----

  deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
  deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
  deps/XenServerJava/src/Makefile PRE-CREATION 
  deps/XenServerJava/src/README.txt PRE-CREATION 
  deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
  deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
  deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
  deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
  deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
  deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
  deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
  deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
  deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
  deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
  deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
  deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
  deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
  deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
  deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
  deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
  deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
  deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
  deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
  deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
  deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
  deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
  deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
  deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
  deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
  deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
  deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
  deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
  deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
  deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
  deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
  deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
  deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
  deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
  deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
  deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
  deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
  deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
  deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
  deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
  deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
  deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
  deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
  deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
  deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
  deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
  deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
  deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
  deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
  deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
  deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 

Diff: https://reviews.apache.org/r/17843/diff/


Testing
-------


Thanks,

Sanjay Tripathi