You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/22 20:32:18 UTC
[GitHub] [spark] hvanhovell commented on issue #27861: [SPARK-30707][SQL]Window function set partitionSpec as order spec when orderSpec is empty
hvanhovell commented on issue #27861:
URL: https://github.com/apache/spark/pull/27861#issuecomment-618023860
So you want to be able to execute row order dependent window functions without specifying an order? That means the result is non deterministic. I am very skeptical about this. If migration is the use case, then we should consider adding a feature flag for it.
Implementation wise I think it is a mistake to do this in the parser. The analyzer seems like a better place to do this, and this avoids that different front-ends behave differently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org