[GitHub] [pinot] Jackie-Jiang commented on issue #8409: Aggregation functions fail on String columns with unfriendly error messages

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on issue #8409:
URL: https://github.com/apache/pinot/issues/8409#issuecomment-1079439498


   Ideally, the check should happen on the broker side since it has access to the table schema, then we may add a string version aggregation (e.g. `StringMax`) to avoid the overhead of overloading `Max` to do non-numeric types. The challenge here is that for transform function, currently we cannot derive the result data type from the input data types.
   
   Another approach is to change `Max` function to return an `Object` instead of `double`. It might involve overhead of storing boxed value, but the result can be of different types (e.g. return `Integer` for int columns instead of double). Currently the final result type must be fixed for aggregation function, so in order to make this change, we need to loose this restriction. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org