[GitHub] [daffodil] tuxji commented on a diff in pull request #947: Add scalafmt

["tuxji (via GitHub)" <gi...@apache.org>]

tuxji commented on code in PR #947:
URL: https://github.com/apache/daffodil/pull/947#discussion_r1098868258


##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/DFDLEscapeScheme.scala:
##########
@@ -36,8 +36,11 @@ import org.apache.daffodil.lib.schema.annotation.props.PropertyLookupResult
 import org.apache.daffodil.lib.schema.annotation.props.NotFound
 import org.apache.daffodil.lib.schema.annotation.props.Found

Review Comment:
   If you expand the diff to look at all the imports, you can see scalafmt did not sort the imports.  I wonder if something is missing from scalafmt's configuration.  BTW, when you try to change the configuration to sort the imports, I would suggest basing your changes on the v4 commit so you can run scalafmt and see from "git diff" more quickly whether scalafmt sorted the imports or not without seeing all the v4 changes obscuring the imports.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org