You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by cshannon <gi...@git.apache.org> on 2018/01/24 16:04:32 UTC
[GitHub] activemq-artemis pull request #1816: ARTEMIS-1633 - fire message routing cal...
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1816
ARTEMIS-1633 - fire message routing callbacks for all results
Make sure ActiveMQServer plugin implementations are always notified of
message route events
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1633
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1816.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1816
----
commit 713c48fd26ce6577b870845ea883b2d90e5915b5
Author: Christopher L. Shannon (cshannon) <ch...@...>
Date: 2018-01-24T16:03:12Z
ARTEMIS-1633 - fire message routing callbacks for all results
Make sure ActiveMQServer plugin implementations are always notified of
message route events
----
---
[GitHub] activemq-artemis pull request #1816: ARTEMIS-1633 - fire message routing cal...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1816
---
[GitHub] activemq-artemis pull request #1816: ARTEMIS-1633 - fire message routing cal...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1816#discussion_r163905434
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java ---
@@ -772,6 +772,8 @@ public RoutingStatus route(final Message message,
message.cleanupInternalProperties();
+ server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> plugin.beforeMessageRoute(message, context, direct, rejectDuplicates) : null);
--- End diff --
in what situation this was not happening? paging?
---
[GitHub] activemq-artemis pull request #1816: ARTEMIS-1633 - fire message routing cal...
Posted by cshannon <gi...@git.apache.org>.
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1816#discussion_r163924828
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java ---
@@ -772,6 +772,8 @@ public RoutingStatus route(final Message message,
message.cleanupInternalProperties();
+ server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> plugin.beforeMessageRoute(message, context, direct, rejectDuplicates) : null);
--- End diff --
If there were messages sent to an address with no bindings the message would get dropped because of lack of bindings. But with the old way the message route methods were only triggered if the routing status was OK. With the change the methods are called even if there are no bindings but the status will say NO_BINDINGS, etc.
---