You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by meenakshisekar <gi...@git.apache.org> on 2016/10/25 12:35:55 UTC
[GitHub] zeppelin pull request #1561: Zeppelin 914 Apply new mechanism to IgniteInter...
GitHub user meenakshisekar opened a pull request:
https://github.com/apache/zeppelin/pull/1561
Zeppelin 914 Apply new mechanism to IgniteInterpreter
What is this PR for?
This handles replacing the registration of interpreter with static block by the interpreter-setting.json file
What type of PR is it?
[| Improvement |
Todos
Sub-Task
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-914
How should this be tested?
There shouldn't be any warning like below on starting the server
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN 2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter Ignite, You should change it to use interpreter-setting.json in your jar or interpreter/{interpreter}/interpreter-setting.json INFO 2016-09-29 00:25:46,250 - Inclass=org.apache.zeppelin.ignite
And ensure that the Ignite related paragraphs run without any error
Screenshots (if appropriate)
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-914
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1561
----
commit 57241368855c62a2975bd44852f77618ddffdbb1
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:40:12Z
Added interpreter setting and removed registration from interperter.
commit 640ad3020a53ce4fbd7965402e877c514232e0c2
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit d7d846b1bc4f42b427cd69aa96e4d6ad195ee3a3
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1561
Hello!
I would like to help with [ZEPPELIN-804](https://issues.apache.org/jira/browse/ZEPPELIN-804) subtasks and make it possible to complete refactoring
If you don't mind I will rebase this PR and take a look at #1077
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1561
@meenakshisekar The failures of this PR is related to actual behavior, not flaky. Can you take a look into the result of the test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1561: Zeppelin 914 Apply new mechanism to IgniteInter...
Posted by meenakshisekar <gi...@git.apache.org>.
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1561
Zeppelin 914 Apply new mechanism to IgniteInterpreter
What is this PR for?
This handles replacing the registration of interpreter with static block by the interpreter-setting.json file
What type of PR is it?
[| Improvement |
Todos
Sub-Task
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-914
How should this be tested?
There shouldn't be any warning like below on starting the server
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN 2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter Ignite, You should change it to use interpreter-setting.json in your jar or interpreter/{interpreter}/interpreter-setting.json INFO 2016-09-29 00:25:46,250 - Inclass=org.apache.zeppelin.ignite
And ensure that the Ignite related paragraphs run without any error
Screenshots (if appropriate)
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-914
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1561
----
commit 57241368855c62a2975bd44852f77618ddffdbb1
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:40:12Z
Added interpreter setting and removed registration from interperter.
commit 640ad3020a53ce4fbd7965402e877c514232e0c2
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit d7d846b1bc4f42b427cd69aa96e4d6ad195ee3a3
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit 18ee9694fb295790171ccd2917ec32f93ef0d883
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-26T10:14:38Z
Corrected the type O
commit 7c328a17c6f043ba4fb3ca358390614cbb66750f
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-26T10:27:25Z
Added indentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1561
@meenakshisekar can you please close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1561: [Zeppelin 914]- Apply new mechanism to IgniteIn...
Posted by meenakshisekar <gi...@git.apache.org>.
Github user meenakshisekar closed the pull request at:
https://github.com/apache/zeppelin/pull/1561
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1561: [Zeppelin 914]- Apply new mechanism to IgniteIn...
Posted by meenakshisekar <gi...@git.apache.org>.
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1561
[Zeppelin 914]- Apply new mechanism to IgniteInterpreter
What is this PR for?
This handles replacing the registration of interpreter with static block by the interpreter-setting.json file
What type of PR is it?
[| Improvement |
Todos
Sub-Task
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-914
How should this be tested?
There shouldn't be any warning like below on starting the server
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN 2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter Ignite, You should change it to use interpreter-setting.json in your jar or interpreter/{interpreter}/interpreter-setting.json INFO 2016-09-29 00:25:46,250 - Inclass=org.apache.zeppelin.ignite
And ensure that the Ignite related paragraphs run without any error
Screenshots (if appropriate)
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-914
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1561
----
commit 57241368855c62a2975bd44852f77618ddffdbb1
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:40:12Z
Added interpreter setting and removed registration from interperter.
commit 640ad3020a53ce4fbd7965402e877c514232e0c2
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit d7d846b1bc4f42b427cd69aa96e4d6ad195ee3a3
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit 18ee9694fb295790171ccd2917ec32f93ef0d883
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-26T10:14:38Z
Corrected the type O
commit 7c328a17c6f043ba4fb3ca358390614cbb66750f
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-26T10:27:25Z
Added indentation
commit 44bc6d1d93893b5c2ef717281c14b4bf620c084b
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-27T11:54:51Z
Added igniteSQl interpreter to the group.
commit 0ec5da8d017507fe2a2bbbd0948edecc70766104
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-31T07:36:35Z
Removed properties in interpreter file and added new line in json file.
commit a8599a49f789c2fdaf2bde424ba47ea964a7ba68
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-31T07:36:35Z
Removed properties in interpreter file and added new line in json file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1561: Zeppelin 914 Apply new mechanism to IgniteInter...
Posted by meenakshisekar <gi...@git.apache.org>.
Github user meenakshisekar closed the pull request at:
https://github.com/apache/zeppelin/pull/1561
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1561: [Zeppelin 914]- Apply new mechanism to IgniteIn...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1561
---
[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...
Posted by meenakshisekar <gi...@git.apache.org>.
Github user meenakshisekar commented on the issue:
https://github.com/apache/zeppelin/pull/1561
Ok sure please go ahead
On Wed, Dec 28, 2016 at 3:29 PM, DrIgor <no...@github.com> wrote:
> Hello!
>
> I would like to help with ZEPPELIN-804
> <https://issues.apache.org/jira/browse/ZEPPELIN-804> subtasks and make it
> possible to complete refactoring
>
> If you don't mind I will rebase this PR and take a look at #1077
> <https://github.com/apache/zeppelin/pull/1077>
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/zeppelin/pull/1561#issuecomment-269454686>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AKjsi4s-lIESQAOnzEj0YICFLs17cr66ks5rMjMagaJpZM4Kf7Ua>
> .
>
--
Thanks & Regards,
Meenakshi.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1561: [Zeppelin 914]- Apply new mechanism to IgniteIn...
Posted by meenakshisekar <gi...@git.apache.org>.
Github user meenakshisekar closed the pull request at:
https://github.com/apache/zeppelin/pull/1561
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1561: Zeppelin 914 Apply new mechanism to IgniteInterpreter
Posted by meenakshisekar <gi...@git.apache.org>.
Github user meenakshisekar commented on the issue:
https://github.com/apache/zeppelin/pull/1561
Reopening for travis build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1561
@meenakshisekar Could you rebase this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1561: Zeppelin 914 Apply new mechanism to IgniteInterpreter
Posted by meenakshisekar <gi...@git.apache.org>.
Github user meenakshisekar commented on the issue:
https://github.com/apache/zeppelin/pull/1561
Reopening for Travis build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1561
New pull request #1819
I rebased it on the latest master and fixed failing test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1561: [Zeppelin 914]- Apply new mechanism to IgniteIn...
Posted by meenakshisekar <gi...@git.apache.org>.
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1561
[Zeppelin 914]- Apply new mechanism to IgniteInterpreter
What is this PR for?
This handles replacing the registration of interpreter with static block by the interpreter-setting.json file
What type of PR is it?
[| Improvement |
Todos
Sub-Task
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-914
How should this be tested?
There shouldn't be any warning like below on starting the server
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN 2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter Ignite, You should change it to use interpreter-setting.json in your jar or interpreter/{interpreter}/interpreter-setting.json INFO 2016-09-29 00:25:46,250 - Inclass=org.apache.zeppelin.ignite
And ensure that the Ignite related paragraphs run without any error
Screenshots (if appropriate)
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-914
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1561
----
commit 57241368855c62a2975bd44852f77618ddffdbb1
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:40:12Z
Added interpreter setting and removed registration from interperter.
commit 640ad3020a53ce4fbd7965402e877c514232e0c2
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit d7d846b1bc4f42b427cd69aa96e4d6ad195ee3a3
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit 18ee9694fb295790171ccd2917ec32f93ef0d883
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-26T10:14:38Z
Corrected the type O
commit 7c328a17c6f043ba4fb3ca358390614cbb66750f
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-26T10:27:25Z
Added indentation
commit 44bc6d1d93893b5c2ef717281c14b4bf620c084b
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-27T11:54:51Z
Added igniteSQl interpreter to the group.
commit 0ec5da8d017507fe2a2bbbd0948edecc70766104
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-31T07:36:35Z
Removed properties in interpreter file and added new line in json file.
commit a8599a49f789c2fdaf2bde424ba47ea964a7ba68
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-31T07:36:35Z
Removed properties in interpreter file and added new line in json file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...
Posted by meenakshisekar <gi...@git.apache.org>.
Github user meenakshisekar commented on the issue:
https://github.com/apache/zeppelin/pull/1561
Reopening for TRavis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1561
@meenakshisekar thank you for contribution! Could you rebase on the latest master please?
Also, please do not hesitate to let us know in case you need any help with this one, in order to get it merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1561: Zeppelin 914 Apply new mechanism to IgniteInter...
Posted by meenakshisekar <gi...@git.apache.org>.
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1561
Zeppelin 914 Apply new mechanism to IgniteInterpreter
What is this PR for?
This handles replacing the registration of interpreter with static block by the interpreter-setting.json file
What type of PR is it?
[| Improvement |
Todos
Sub-Task
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-914
How should this be tested?
There shouldn't be any warning like below on starting the server
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN 2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter Ignite, You should change it to use interpreter-setting.json in your jar or interpreter/{interpreter}/interpreter-setting.json INFO 2016-09-29 00:25:46,250 - Inclass=org.apache.zeppelin.ignite
And ensure that the Ignite related paragraphs run without any error
Screenshots (if appropriate)
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-914
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1561
----
commit 57241368855c62a2975bd44852f77618ddffdbb1
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:40:12Z
Added interpreter setting and removed registration from interperter.
commit 640ad3020a53ce4fbd7965402e877c514232e0c2
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit d7d846b1bc4f42b427cd69aa96e4d6ad195ee3a3
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit 18ee9694fb295790171ccd2917ec32f93ef0d883
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-26T10:14:38Z
Corrected the type O
commit 7c328a17c6f043ba4fb3ca358390614cbb66750f
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-26T10:27:25Z
Added indentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1561: Zeppelin 914 Apply new mechanism to IgniteInter...
Posted by meenakshisekar <gi...@git.apache.org>.
Github user meenakshisekar closed the pull request at:
https://github.com/apache/zeppelin/pull/1561
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---