You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/11/17 02:08:58 UTC
[GitHub] [helix] kaisun2000 opened a new pull request #1535: fix TestHelixAdminCli testDeactivateCluster flakiness
kaisun2000 opened a new pull request #1535:
URL: https://github.com/apache/helix/pull/1535
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
fix #1300
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
fix TestHelixAdminCli testDeactivateCluster flakiness. As this
test does not wait till the cluster converge before tearing it
down. The tearing down process can have exceptions depending on
timing.
(Write a concise description including what, why, how)
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- [ ] The following is the result of the "mvn test" command on the appropriate module:
(Before CI test pass, please copy & paste the result of "mvn test")
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #1535: fix TestHelixAdminCli testDeactivateCluster flakiness
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1535:
URL: https://github.com/apache/helix/pull/1535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1535: fix TestHelixAdminCli testDeactivateCluster flakiness
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1535:
URL: https://github.com/apache/helix/pull/1535#discussion_r525398313
##########
File path: helix-core/src/test/java/org/apache/helix/tools/TestHelixAdminCli.java
##########
@@ -603,6 +611,12 @@ public void testDeactivateCluster() throws Exception {
command = "-zkSvr localhost:2183 -dropCluster " + clusterName;
ClusterSetup.processCommandLineArgs(command.split("\\s"));
+ boolean leaderNotExists = TestHelper.verify(() -> {
+ boolean isLeaderExists = _gZkClient.exists(path);
+ return isLeaderExists == false;
+ }, 10000L);
Review comment:
nit, TestHelper.WAIT_DURATION?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on a change in pull request #1535: fix TestHelixAdminCli testDeactivateCluster flakiness
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on a change in pull request #1535:
URL: https://github.com/apache/helix/pull/1535#discussion_r525467879
##########
File path: helix-core/src/test/java/org/apache/helix/tools/TestHelixAdminCli.java
##########
@@ -603,6 +611,12 @@ public void testDeactivateCluster() throws Exception {
command = "-zkSvr localhost:2183 -dropCluster " + clusterName;
ClusterSetup.processCommandLineArgs(command.split("\\s"));
+ boolean leaderNotExists = TestHelper.verify(() -> {
+ boolean isLeaderExists = _gZkClient.exists(path);
+ return isLeaderExists == false;
+ }, 10000L);
Review comment:
changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on pull request #1535: fix TestHelixAdminCli testDeactivateCluster flakiness
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on pull request #1535:
URL: https://github.com/apache/helix/pull/1535#issuecomment-729166641
This PR is approved, please help to merge in
>fix TestHelixAdminCli testDeactivateCluster flakiness. As this
test does not wait till the cluster converge before tearing it
down. The tearing down process can have exceptions depending on
timing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org