You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/10 01:01:47 UTC
[GitHub] [flink-table-store] LadyForest opened a new pull request, #116: [FLINK-27558] Introduce a new optional option for TableStoreFactory to represent planned manifest entries
LadyForest opened a new pull request, #116:
URL: https://github.com/apache/flink-table-store/pull/116
When `TableStoreFactory.onCompactTable`gets called, the planned manifest entries need to be injected back into the enriched options, and we need a new key to represent it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #116: [FLINK-27558] Introduce a new optional option for TableStoreFactory to represent planned manifest entries
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #116:
URL: https://github.com/apache/flink-table-store/pull/116#discussion_r868862749
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStoreFactoryOptions.java:
##########
@@ -39,6 +39,14 @@ public class TableStoreFactoryOptions {
+ "By default, compaction does not adjust the bucket number "
+ "of a partition/table.");
+ public static final ConfigOption<String> COMPACTION_SCANNED_MANIFEST =
Review Comment:
Add a internal annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #116: [FLINK-27558] Introduce a new optional option for TableStoreFactory to represent planned manifest entries
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #116:
URL: https://github.com/apache/flink-table-store/pull/116#discussion_r868862596
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStoreFactoryOptions.java:
##########
@@ -39,6 +39,14 @@ public class TableStoreFactoryOptions {
+ "By default, compaction does not adjust the bucket number "
+ "of a partition/table.");
+ public static final ConfigOption<String> COMPACTION_SCANNED_MANIFEST =
Review Comment:
Can you add format information in description? (how to serialize manifest entry to string?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #116: [FLINK-27558] Introduce a new optional option for TableStoreFactory to represent planned manifest entries
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #116:
URL: https://github.com/apache/flink-table-store/pull/116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org