[GitHub] [superset] ktmud commented on issue #12566: [SIP-57] Proposal for Semantic Versioning

[GitBox <gi...@apache.org>]

ktmud commented on issue #12566:
URL: https://github.com/apache/superset/issues/12566#issuecomment-761929142


   Thank you for the comphrensive writeup! I learned a lot from reading this.
   
   Some thoughts on a first pass:
   
   > - Feature or Config Flags
   >   - Setting a new flag where the default would break any existing functionality
   
   We should never allow a new flag to change the default. A feature flag is like an A/B test, it should only add or change features when the flag is set to true, which shall not start as the default.
   
   > -UI
   >   - changes that would break existing charts, dashboards, queries, or favorites
   
   Would love to see an expansion on this in terms of how the UI may break. E.g.
   
   - Changes that removes an existing functionality
   - Changes that replaces an existing feature without a clear alternative solution
   
   
   We should also start thinking about breaking changes for the plugin systems, e.g., how the controls are defined, how query objects are built, and how charts are rendered... Currently it's in a "use at your own risk" state, but as the API matures, we may want to define any updates to `superset-ui` and the viz control related code in `superset-frontend` that break an existing viz plugin to be also a breaking change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org