You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/04/08 23:15:15 UTC
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1081:
Speed up some more tests
ctubbsii commented on a change in pull request #1081: Speed up some more tests
URL: https://github.com/apache/accumulo/pull/1081#discussion_r273269659
##########
File path: test/src/main/java/org/apache/accumulo/test/TableOperationsIT.java
##########
@@ -59,20 +59,38 @@
import org.apache.accumulo.core.security.TablePermission;
import org.apache.accumulo.core.tabletserver.thrift.TabletClientService;
import org.apache.accumulo.harness.AccumuloClusterHarness;
+import org.apache.accumulo.harness.MiniClusterConfigurationCallback;
+import org.apache.accumulo.harness.SharedMiniClusterBase;
+import org.apache.accumulo.minicluster.MemoryUnit;
+import org.apache.accumulo.minicluster.ServerType;
+import org.apache.accumulo.miniclusterImpl.MiniAccumuloConfigImpl;
import org.apache.accumulo.test.functional.BadIterator;
import org.apache.accumulo.test.functional.FunctionalTestUtils;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.RawLocalFileSystem;
import org.apache.hadoop.io.Text;
import org.junit.After;
+import org.junit.AfterClass;
import org.junit.Before;
+import org.junit.BeforeClass;
import org.junit.Test;
import com.google.common.collect.Sets;
-public class TableOperationsIT extends AccumuloClusterHarness {
Review comment:
This makes these tests no longer standalone-capable, meaning they will only ever run in Mini, but not against a real cluster, if one had configured that. It's good for speeding things up a tiny bit, but it's a slight loss of functionality, only done for sharing resources, but not done because there's actually a good reason to make it mini-only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services