You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Gary Dusbabek (JIRA)" <ji...@apache.org> on 2011/01/07 15:27:46 UTC

[jira] Created: (CASSANDRA-1949) Message translation

Message translation
-------------------

                 Key: CASSANDRA-1949
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
             Project: Cassandra
          Issue Type: Sub-task
            Reporter: Gary Dusbabek
            Assignee: Gary Dusbabek




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1949) Message translation

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1949:
-------------------------------------

    Attachment:     (was: v1-0005-introduce-version-to-ICompactSerializer-convert-a-few-.txt)

> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-bump-MessagingService.version_.txt, v2-0002-introduce-version-to-Message-pt-1.txt, v2-0003-introduce-version-to-Message-pt-2.txt, v2-0004-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v2-0005-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-1949) Message translation

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990357#comment-12990357 ] 

Gary Dusbabek commented on CASSANDRA-1949:
------------------------------------------

Rebased.

> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-bump-MessagingService.version_.txt, v2-0002-introduce-version-to-Message-pt-1.txt, v2-0003-introduce-version-to-Message-pt-2.txt, v2-0004-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v2-0005-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CASSANDRA-1949) Message translation

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1949:
-------------------------------------

    Attachment: v1-0006-fix-incompatible-serializations.txt
                v1-0005-introduce-version-to-ICompactSerializer-convert-a-few-.txt
                v1-0004-introduce-version-to-Message-pt-2.txt
                v1-0003-introduce-version-to-Message-pt-1.txt
                v1-0002-bump-MessagingService.version_.txt
                v1-0001-ignore-messages-from-newer-versions-keep-track-of-node.txt

> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.7.2
>
>         Attachments: v1-0001-ignore-messages-from-newer-versions-keep-track-of-node.txt, v1-0002-bump-MessagingService.version_.txt, v1-0003-introduce-version-to-Message-pt-1.txt, v1-0004-introduce-version-to-Message-pt-2.txt, v1-0005-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v1-0006-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1949) Message translation

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1949:
-------------------------------------

    Attachment:     (was: v1-0003-introduce-version-to-Message-pt-1.txt)

> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-bump-MessagingService.version_.txt, v2-0002-introduce-version-to-Message-pt-1.txt, v2-0003-introduce-version-to-Message-pt-2.txt, v2-0004-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v2-0005-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CASSANDRA-1949) Message translation

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1949:
-------------------------------------

    Attachment:     (was: v1-0001-ignore-messages-from-newer-versions-keep-track-of-node.txt)

> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-bump-MessagingService.version_.txt, v2-0002-introduce-version-to-Message-pt-1.txt, v2-0003-introduce-version-to-Message-pt-2.txt, v2-0004-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v2-0005-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CASSANDRA-1949) Message translation

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1949:
-------------------------------------

    Attachment:     (was: v1-0002-bump-MessagingService.version_.txt)

> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-bump-MessagingService.version_.txt, v2-0002-introduce-version-to-Message-pt-1.txt, v2-0003-introduce-version-to-Message-pt-2.txt, v2-0004-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v2-0005-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-1949) Message translation

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990804#comment-12990804 ] 

Brandon Williams commented on CASSANDRA-1949:
---------------------------------------------

+1.  Minor OCD nit: "Cacheing" -> "Caching"

> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-bump-MessagingService.version_.txt, v2-0002-introduce-version-to-Message-pt-1.txt, v2-0003-introduce-version-to-Message-pt-2.txt, v2-0004-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v2-0005-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CASSANDRA-1949) Message translation

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1949:
-------------------------------------

    Attachment: v2-0005-fix-incompatible-serializations.txt
                v2-0004-introduce-version-to-ICompactSerializer-convert-a-few-.txt
                v2-0003-introduce-version-to-Message-pt-2.txt
                v2-0002-introduce-version-to-Message-pt-1.txt
                v2-0001-bump-MessagingService.version_.txt

> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-bump-MessagingService.version_.txt, v2-0002-introduce-version-to-Message-pt-1.txt, v2-0003-introduce-version-to-Message-pt-2.txt, v2-0004-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v2-0005-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-1949) Message translation

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991438#comment-12991438 ] 

Hudson commented on CASSANDRA-1949:
-----------------------------------

Integrated in Cassandra #712 (See [https://hudson.apache.org/hudson/job/Cassandra/712/])
    metadata update. patch by gdusbabek, reviewed by brandonwilliams. CASSANDRA-1949
fix incompatible serializations. patch by gdusbabek, reviewed by brandonwilliams. CASSANDRA-1949
introduce version to ICompactSerializer, convert a few to ICompactSerializer2. patch by gdusbabek, reviewed by brandonwilliams. CASSANDRA-1949
introduce version to Message, pt 2. patch by gdusbabek, reviewed by brandonwilliams. CASSANDRA-1949
introduce version to Message, pt 1. patch by gdusbabek, reviewed by brandonwilliams. CASSANDRA-1949
bump MessagingService.version_. patch by gdusbabek, reviewed by brandonwilliams. CASSANDRA-1949


> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-bump-MessagingService.version_.txt, v2-0002-introduce-version-to-Message-pt-1.txt, v2-0003-introduce-version-to-Message-pt-2.txt, v2-0004-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v2-0005-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CASSANDRA-1949) Message translation

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1949:
-------------------------------------

    Attachment:     (was: v1-0006-fix-incompatible-serializations.txt)

> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-bump-MessagingService.version_.txt, v2-0002-introduce-version-to-Message-pt-1.txt, v2-0003-introduce-version-to-Message-pt-2.txt, v2-0004-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v2-0005-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CASSANDRA-1949) Message translation

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1949:
-------------------------------------

    Attachment:     (was: v1-0004-introduce-version-to-Message-pt-2.txt)

> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-bump-MessagingService.version_.txt, v2-0002-introduce-version-to-Message-pt-1.txt, v2-0003-introduce-version-to-Message-pt-2.txt, v2-0004-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v2-0005-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-1949) Message translation

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987219#action_12987219 ] 

Gary Dusbabek commented on CASSANDRA-1949:
------------------------------------------

Here are the situations I tested:
1. brought up two 0.7 nodes. Loaded schema with RF=2 and did some writes.
2. brought down one of the nodes, did some writes on the single live node.
3. brought up the trunk node, saw it get the schema from the 0.7 node.
4. issued a repair on the 0.7 node.
5. did some writes at CL.ALL.
6. brought up a third trunk node, saw it get the schema and stream from both (trunk and 0.7) nodes.
7. did some writes on the entire cluster at CL.ALL.

> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v1-0001-ignore-messages-from-newer-versions-keep-track-of-node.txt, v1-0002-bump-MessagingService.version_.txt, v1-0003-introduce-version-to-Message-pt-1.txt, v1-0004-introduce-version-to-Message-pt-2.txt, v1-0005-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v1-0006-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CASSANDRA-1949) Message translation

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987215#comment-12987215 ] 

Gary Dusbabek edited comment on CASSANDRA-1949 at 2/4/11 9:00 PM:
------------------------------------------------------------------

0001 attaches a version to Messages.  The version isn't included in the serialization because MessagingService.packit handles that.  Messages are created according to the version on the host destined to receive the message.
0003 is a continuation of the previous but handles the hard cases (where we were sending a single message to multiple hosts--we can't assume they are on the same protocol version anymore). 
0004 adds a version parameter to the ICompactSerializer interface.  This is where the translation happens.
0005 fixes the place where we have broken compatibility between 0.7 and trunk.

      was (Author: gdusbabek):
    0001 is the same as the patch on CASSANDRA-1970
0003 attaches a version to Messages.  The version isn't included in the serialization because MessagingService.packit handles that.  Messages are created according to the version on the host destined to receive the message.
0004 is a continuation of the previous but handles the hard cases (where we were sending a single message to multiple hosts--we can't assume they are on the same protocol version anymore). 
0005 adds a version parameter to the ICompactSerializer interface.  This is where the translation happens.
0006 fixes the place where we have broken compatibility between 0.7 and trunk.
  
> Message translation
> -------------------
>
>                 Key: CASSANDRA-1949
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1949
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-bump-MessagingService.version_.txt, v2-0002-introduce-version-to-Message-pt-1.txt, v2-0003-introduce-version-to-Message-pt-2.txt, v2-0004-introduce-version-to-ICompactSerializer-convert-a-few-.txt, v2-0005-fix-incompatible-serializations.txt
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira