Re: [PR] chore(export): Added ability to export chart YAML files with Unicode characters, fix #20331 [superset]

["codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>]

codeant-ai-for-open-source[bot] commented on code in PR #28008:
URL: https://github.com/apache/superset/pull/28008#discussion_r3392409881


##########
tests/integration_tests/datasets/commands_tests.py:
##########
@@ -273,6 +273,37 @@ def test_export_dataset_command_no_related(self, mock_g):
             f"datasets/examples/energy_usage_{example_dataset.id}.yaml",
         ]
 
+    @patch("superset.security.manager.g")
+    def test_export_dataset_command_unicode_chars(self, mock_g):
+        mock_g.user = security_manager.find_user("admin")
+        examples_db = get_example_database()
+        with examples_db.get_sqla_engine() as engine:
+            engine.execute("DROP TABLE IF EXISTS 中文")
+            engine.execute("CREATE TABLE 中文 AS SELECT 2 as col")
+        if db.session.query(SqlaTable).filter_by(table_name="中文").count():
+            db.session.query(SqlaTable).filter_by(table_name="中文").delete()

Review Comment:
   **Suggestion:** The cleanup query deletes datasets by `table_name` only, without scoping to the current example database. If another database contains a dataset with the same table name, this test will delete unrelated rows and can make other tests fail unpredictably. Restrict the deletion to the target database (for example by `database_id`) before creating the new dataset. [logic error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ⚠️ Other databases' datasets named 中文 deleted during test cleanup.
   - ⚠️ Integration tests may fail when sharing table_name 中文.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Before running the dataset tests, create a dataset with `table_name="中文"` on a
   non-example database by calling `CreateDatasetCommand({"table_name": "中文", "database":
   <other_db_id>}).run()` (implemented in `superset/commands/dataset/create.py:3-13`, which
   persists a new `SqlaTable` row with `database_id=<other_db_id>`).
   
   2. Run the integration test `test_export_dataset_command_unicode_chars` defined at
   `tests/integration_tests/datasets/commands_tests.py:276-305`, which sets up a physical
   table `中文` on `examples_db` and prepares to create a dataset for it.
   
   3. Inside this test, the cleanup guard at
   `tests/integration_tests/datasets/commands_tests.py:281-285` executes
   
      `if db.session.query(SqlaTable).filter_by(table_name="中文").count():
      db.session.query(SqlaTable).filter_by(table_name="中文").delete()`
   
      (the delete is at line 284), issuing a DELETE scoped only by `table_name` and not by
      `database_id`.
   
   4. After the test finishes, run `db.session.query(SqlaTable).filter_by(table_name="中文",
   database_id=<other_db_id>).one_or_none()` in the same test process and observe that it
   returns `None`, showing that the unrelated dataset on the other database was deleted by
   this test's cleanup.
   ```
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3f84619968dd4f91b9bc9a4978f03ef4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3f84619968dd4f91b9bc9a4978f03ef4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** tests/integration_tests/datasets/commands_tests.py
   **Line:** 284:284
   **Comment:**
   	*Logic Error: The cleanup query deletes datasets by `table_name` only, without scoping to the current example database. If another database contains a dataset with the same table name, this test will delete unrelated rows and can make other tests fail unpredictably. Restrict the deletion to the target database (for example by `database_id`) before creating the new dataset.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F28008&comment_hash=827da957c12b4603f95a7b9b6e134f929033001261c0b8ab5d0c7d625f6139bb&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F28008&comment_hash=827da957c12b4603f95a7b9b6e134f929033001261c0b8ab5d0c7d625f6139bb&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org