You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/04 14:38:48 UTC

[GitHub] [arrow] edponce commented on a diff in pull request #12460: ARROW-13530: [C++] Implement cumulative sum compute function

edponce commented on code in PR #12460:
URL: https://github.com/apache/arrow/pull/12460#discussion_r841815697


##########
python/pyarrow/_compute.pyx:
##########
@@ -1736,6 +1736,28 @@ class PartitionNthOptions(_PartitionNthOptions):
         self._set_options(pivot, null_placement)
 
 
+cdef class _CumulativeGenericOptions(FunctionOptions):
+    def _set_options(self, start, skip_nulls):
+        self.wrapped.reset(new CCumulativeGenericOptions(
+            pyarrow_unwrap_scalar(start), skip_nulls))
+
+
+class CumulativeGenericOptions(_CumulativeGenericOptions):
+    """
+    Options for `cumulative_sum` function.
+
+    Parameters
+    ----------
+    start : Scalar

Review Comment:
   Add a Python test because input is Scalar and need to ensure it is handled correctly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org