You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by lukewpatterson <lu...@gmail.com> on 2010/12/21 14:39:29 UTC
feedback on maven-invoker-plugin patches
Hi,
I created two issues for maven-invoker-plugin:
"duplicate script classpath entries are not filtered out, can cause
ClassCastException" - http://jira.codehaus.org/browse/MINVOKER-112
and
"update to Groovy 1.7.5 (from 1.5.6)" -
http://jira.codehaus.org/browse/MINVOKER-113
The first issue is a bug and the second is an improvement. I've attached
some clean, straight-forward patches to each.
Any feedback is appreciated. I'm hoping those can get applied soon. Also,
if there's interest, I can contribute some time to get the project Java 5'd
(adding generics, enhanced for loops, etc.).
Thanks,
Luke
--
View this message in context: http://maven.40175.n5.nabble.com/feedback-on-maven-invoker-plugin-patches-tp3313521p3313521.html
Sent from the Maven Developers mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: feedback on maven-invoker-plugin patches
Posted by lukewpatterson <lu...@gmail.com>.
Thanks for the blazing-fast help, Olivier.
Regarding the Java 5 language updates I referred to in my original post, I
created http://jira.codehaus.org/browse/MINVOKER-114 MINVOKER-114 .
--
View this message in context: http://maven.40175.n5.nabble.com/feedback-on-maven-invoker-plugin-patches-tp3313521p3315179.html
Sent from the Maven Developers mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: feedback on maven-invoker-plugin patches
Posted by Olivier Lamy <ol...@apache.org>.
Done and applied.
Thanks !
--
Olivier
2010/12/21 Olivier Lamy <ol...@apache.org>:
> Hello,
> I will have a look.
>
> 2010/12/21 lukewpatterson <lu...@gmail.com>:
>>
>> Hi,
>>
>> I created two issues for maven-invoker-plugin:
>>
>> "duplicate script classpath entries are not filtered out, can cause
>> ClassCastException" - http://jira.codehaus.org/browse/MINVOKER-112
>>
>> and
>>
>> "update to Groovy 1.7.5 (from 1.5.6)" -
>> http://jira.codehaus.org/browse/MINVOKER-113
>>
>>
>> The first issue is a bug and the second is an improvement. I've attached
>> some clean, straight-forward patches to each.
>>
>> Any feedback is appreciated. I'm hoping those can get applied soon. Also,
>> if there's interest, I can contribute some time to get the project Java 5'd
>> (adding generics, enhanced for loops, etc.).
>>
>>
>> Thanks,
>>
>> Luke
>> --
>> View this message in context: http://maven.40175.n5.nabble.com/feedback-on-maven-invoker-plugin-patches-tp3313521p3313521.html
>> Sent from the Maven Developers mailing list archive at Nabble.com.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy
> http://www.linkedin.com/in/olamy
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: feedback on maven-invoker-plugin patches
Posted by Olivier Lamy <ol...@apache.org>.
Hello,
I will have a look.
2010/12/21 lukewpatterson <lu...@gmail.com>:
>
> Hi,
>
> I created two issues for maven-invoker-plugin:
>
> "duplicate script classpath entries are not filtered out, can cause
> ClassCastException" - http://jira.codehaus.org/browse/MINVOKER-112
>
> and
>
> "update to Groovy 1.7.5 (from 1.5.6)" -
> http://jira.codehaus.org/browse/MINVOKER-113
>
>
> The first issue is a bug and the second is an improvement. I've attached
> some clean, straight-forward patches to each.
>
> Any feedback is appreciated. I'm hoping those can get applied soon. Also,
> if there's interest, I can contribute some time to get the project Java 5'd
> (adding generics, enhanced for loops, etc.).
>
>
> Thanks,
>
> Luke
> --
> View this message in context: http://maven.40175.n5.nabble.com/feedback-on-maven-invoker-plugin-patches-tp3313521p3313521.html
> Sent from the Maven Developers mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Olivier Lamy
http://twitter.com/olamy
http://www.linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org