You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/31 11:20:43 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #10403: Fix duration object in Dataproc cluster generator

mik-laj commented on a change in pull request #10403:
URL: https://github.com/apache/airflow/pull/10403#discussion_r480065195



##########
File path: airflow/providers/google/cloud/operators/dataproc.py
##########
@@ -157,8 +157,8 @@ class ClusterGenerator:
     # pylint: disable=too-many-arguments,too-many-locals
     def __init__(
         self,
-        project_id: Optional[str] = None,
-        cluster_name: Optional[str] = None,
+        project_id: str,

Review comment:
       Should we add fallback for project ID from service account?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org